search

refresh-bio / KMC

Fast and frugal disk based k-mer counter
256 stars 73 forks source link

abi version? #101

Closed notestaff closed 5 years ago

notestaff commented 6 years ago

@marekkokot at https://github.com/refresh-bio/KMC/blob/master/makefile#L89 what is the reason for the abi version option?

marekkokot commented 5 years ago

Well,

KMC uses vectorclasslib to detect cpu instruction set. vectorclasslib documentation says that under g++ vectroclasslib should be compiled with -fabi-version=0, although I think it was not needed to just detect available instruction set. Nevertheless vectorclasslib dependency was dropped with 4df82be238b00e814efc782c468045d482ec3737 and with 2503a4d02058f7c50386df3934f53350031f1eac this flag was removed. I have also removed -mfma which was probably accidentally added to makefile.