search

refstudycentre / 2014

Zen-based Drupal theme (2014 design) for RSC websites
GNU General Public License v2.0
0 stars 0 forks source link

Create a Makefile #4

Open rudolfbyker opened 8 years ago

rudolfbyker commented 8 years ago

The rsc2014 and rsc14_cl subthemes have scss files which have to be compiled to css. A specific version of compass is needed to make it work with the Zen theme. See https://www.drupal.org/node/2353067#comment-9567305 for more info. I have to look that up every time I update the theme, which is a hassle.

We need a Makefile (or two?) which compiles the scss with either compass _0.12.6_ watch or compass _0.12.6_ compile

rudolfbyker commented 7 years ago

Commits 54a657d57574c8bea014485e3866ceaa946622ad and ff6ae472dfd6496313ddf304720bd2c0530c918e attempt to address this problem by including the .css files in the repo. I don't think that's an optimal solution. @krokkie please comment.

krokkie commented 7 years ago

This is somewhat of a pragmatic hack.
But I guess there is no harm in including the CSS files.

We are using "drush make" to pull this theme/repo in some of the sites. The "drush make" command does not automatically compile the compass stuff, so we end up using a theme without any CSS files. If there is a way to make the "drush make" command do this automatically, it would be better. Sounds like https://www.drupal.org/project/drush_compass might provide some of this functionality - not sure.

rudolfbyker commented 7 years ago

Includiing css files causes lots of merge conflicts, since one line of scss can change many lines of css in many different places. Workaround: Always use merge strategy ours for .css files.