refugeehackathon / interpreteer-backend

Interpreteer helps newcomers find an interpreter
GNU General Public License v2.0
1 stars 0 forks source link

add oauth backend, enable login for local users #46

Open hrantzsch opened 8 years ago

hrantzsch commented 8 years ago

add basic oauth backend. also removed unused base folder

dahoo commented 8 years ago

The tests are failing. Did you forget to add oauth2 to the requirements or something like that?

illing2005 commented 8 years ago

You removed "rest_framework" from installed apps. That might be the problem: https://github.com/refugeehackathon/interpreteer-backend/pull/46/files#diff-29

Did you also remove the Facebook Login?

hrantzsch commented 8 years ago

woops, forgot to add new requirements

hrantzsch commented 8 years ago

Ok, checks are being passed now. Did you see that we removed the base-stuff as well? Frontend would run on it's own then and there's no route that belongs to '/'. Christian argues we could redirect to api/docs or something similar.

dahoo commented 8 years ago

:+1:

illing2005 commented 8 years ago

Still wondering why you removed rest_framework from INSTALLED_APPS https://github.com/refugeehackathon/interpreteer-backend/pull/46/files#diff-29

Also it would be great, if you could add some tests :)

dahoo commented 8 years ago

Oh, forgot that. It's indeed missing, I get the error TemplateDoesNotExist at /api/offers/.

hrantzsch commented 8 years ago

Sorry, of course you are right. rest_framework was not supposed to be removed