Open raigorai opened 5 years ago
Hi. We're interested in your use case.
Perhaps this is not just gitlab plugin's issue.
I think we should introduce something like "project name" into reg-suit in order to use reg-suit with mono-repo.
For example:,
packages/service-A/regconfig.json
{
"project": {
"name": "service-A",
},
"core": {...},
"plugins": {...}
}
packages/service-B/regconfig.json
{
"project": {
"name": "service-B",
},
"core": {...},
"plugins": {...}
}
And the project.name
property will be used from:
@Quramy
Same request here.
I'm currently using reg-suit for iOS application products.
I have plans to develop multiple applications in mono-repo in the future and it would be useful to be able to display a separate report for each, IMO.
I think to do that, in addition to the way you mention above, you'd need to be able to configure actualDir
on a per-project basis.
@Quramy same use case here, having this project name setting would be amazing.
We don't even need this custom directory inside S3, we could use different buckets for each service inside the monorepo. However, the COMMENT_MARK is crucial. Being able to create a new github check would be nice as well, at the moment only one is displayed.
Do you accept PRs?
For a workaround, we can refer to Chromatic;
Chromatic provides the following two options for the monorepo use cases. https://www.chromatic.com/docs/monorepos
--preserve-missing
flag, Chromatic will pass the baselines forward and treat all missing stories as “preserved” without re-capturing them. Which means that we can only test a subset of stories.These can also be applied to reg-suit.
reg-suit
doesn't have an option like --preserve-missing
, it is likely to be necessary to capture Storybook of all projects every time. If it's OK for you, you can use this pattern (but if you have a huge number of projects in your monorepo, It doesn't seem to be scalable in principle)reg-suit
more than once in a second Chromatic projectreg-suit run
in each of all monorepo projectsreg-suit
because, as others have pointed out, only single comment will be created and overwritten (prCommentBehavior: new
doesn't scale for monorepos with many projects)@Quramy any news about a solution to run inside monorepos? We're really interested to run reg-suit in our projects!
I too hope to take advantage of this use case.
I want to display multiple reports in one pull request or merge request.
This is because a single repository manages multiple microservices. When a
reg-suit run
is run for each microservice, the report on the merge request is overwritten.https://github.com/reg-viz/reg-suit/blob/master/packages/reg-notify-gitlab-plugin/src/use-cases.ts#L13 If I can set the COMMENT_MARK value arbitrarily, I can solve this problem.
Is there a plan to fix it?