reg-viz / reg-suit

:recycle: Visual Regression Testing tool
https://reg-viz.github.io/reg-suit
MIT License
1.17k stars 101 forks source link

fix: pass expectedKey after syncExpected #618

Closed mugi-uno closed 5 months ago

mugi-uno commented 1 year ago

What does this change?

I'm using own Slack Notify plugin and we want to notify expectedKey through it. However, currently in the syncExpected function in reg-suit-core, it's not passing the ctx argument, causing expectedKey to be lost. Therefore, I modified syncExpected to include the contents of the ctx argument in its return value.

(I thought it would be appropriate to inherit the contents of ctx because the return type is also StepResultAfterExpectedKey.)

References

nothing

Screenshots

nothing

What can I check for bug fixes?

I have enabled any Publisher plugin and executed run with the --verbose flag. I checked the "expectedKey" log output and confirmed that it was displayed in the form of "Notify parameters:".