reg-viz / reg-suit

:recycle: Visual Regression Testing tool
https://reg-viz.github.io/reg-suit
MIT License
1.17k stars 101 forks source link

When I run a reg-suit run more than once on the same PR CI, I want more than one comment on the results. #691

Open amyu opened 6 months ago

amyu commented 6 months ago

Thanks for an awesome Library!

Is your feature request related to a problem? Please describe.

I have several Projects in my Repository. I use reg-suit in each Project and I use reg-notify-github-plugin to post comments on PR. Therefore, I have set up GHA as follows.

- run: |
  cd hoge
  reg-suit run

- run: |
  cd fuga
  reg-suit run

However, in this configuration, only the results of the last reg-suit run are commented. For example, is it in line with this Library's policy to add features like the following PR? https://github.com/amyu/gh-app/pull/1 https://github.com/amyu/reg-suit/pull/1 In the PR above, we added an argument name. Setting this name will link a Comment to a name.

- run: |
  cd hoge
  reg-suit run # regconfig.json { name: 'hoge' }

- run: |
  cd fuga
  reg-suit run # regconfig.json { name: 'fuga' }

name: hoge :sparkles::sparkles: That's perfect, there is no visual difference! :sparkles::sparkles:


name: fuga :sparkles::sparkles: That's perfect, there is no visual difference! :sparkles::sparkles:

Two will be posted as in the example above. It will also be posted if there are no comments yet, or if a comment has already been posted by a reg-suit but there is no comment associated with the name. When updating, if name is set, it will be updated appropriately for each behavior.

I would be very grateful if you would consider it.

Describe the solution you'd like

If there is no major problem with the above PR, I will add Test, etc. and submit it to PR.

Describe alternatives you've considered

Additional context

I would like to see a feature like the one in Zenn below. https://zenn.dev/fraim/articles/e020e82985ac6d#%E4%B8%80%E3%81%A4%E3%81%AEpr%E3%81%A7%E8%A4%87%E6%95%B0%E3%81%AEvrt%E3%82%92%E8%A1%8C%E3%81%86