search

rega-cev / phylogeotool

4 stars 3 forks source link

Enable PPlacer in http://phylogeotool.gbiomed.kuleuven.be/dengue/ #12

Closed plibin closed 7 years ago

Ewout1988 commented 7 years ago

It's activated and should be working

screen shot 2017-05-05 at 17 16 32

GuyBaele commented 7 years ago

Should the phylogenetic placement window accept an AA sequence? For example, I can copy paste the following sequence into the window and submit it without getting a warning or error message:

seq1 KYRTWEEFTRAAEKLYQADPMKVRVVLKYRHCDGNLCIKVTDDVVCLLYRTDQAQDVKKIEKFHSQLMRLME LKVTDNKECLKFKTDQAQEAKKMEKLNNIFFTLM

plibin commented 7 years ago

an error should indeed be thrown

ktheyss commented 7 years ago

An AA sequence will not pass the blast step, so no placement will happen. For me, the error message should be the same for an AA than for a different virus, a different region, etc.

I do not see the added value of making a special error message for a AA sequence.

Ewout1988 commented 7 years ago

Let's continue this discussion here: #28 This issue (dengue pplacer) can be closed