Closed Ewout1988 closed 7 years ago
You mean the gradient?
I don't get what this issue is about ...
It's about the fact that people were confused on what is being visualised on the map. Is it the 'Country of origin', 'Country of infection', ...
So not Guy’s issue about gradient? This is not in Gihub yet?
After reading about it, I think this is related to your issue, about geographical regions gradient coloring and the number of taxa in the clusters.
Is this correct Ewout?
Guy proposed a solution to fix this: putting a label with the gradient legend, right?
I don't think that they are completely similar. @GuyBaele is more confused by the fact that the amount of taxa isn't really lining up with the amount of sequences in a cluster. There's two reasons for this:
Lize on the other hand simply doesn't know which value is represented on the map, something we could add in the top right corner of the map for example?
On 26 Apr 2017, at 14:05, Ewout1988 notifications@github.com<mailto:notifications@github.com> wrote:
I don't think that they are completely similar. @GuyBaelehttps://github.com/GuyBaele is more confused by the fact that the amount of taxa isn't really lining up with the amount of sequences in a cluster. There's two reasons for this:
Would a better legend help with this? (This is what Guy proposed)
Lize on the other hand simply doesn't know which value is represented on the map, something we could add in the top right corner of the map for example?
OK
Can you split these issues in 2 clear issues?
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/rega-cev/phylogeotool/issues/17#issuecomment-297382310, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFLrgimGsY01hK_n6xHZ7iZudC-_6aACks5rzzL-gaJpZM4NH1dk.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rega-cev/phylogeotool","title":"rega-cev/phylogeotool","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rega-cev/phylogeotool"}},"updates":{"snippets":[{"icon":"PERSON","message":"@Ewout1988 in #17: I don't think that they are completely similar.\r\n@GuyBaele is more confused by the fact that the amount of taxa isn't really lining up with the amount of sequences in a cluster. There's two reasons for this:\r\n\r\n1. The number to the right of the gradient legend is the maximum amount of sequences in one country. If you take for example http://phylogeotool.gbiomed.kuleuven.be/euresist/ then 11,169 are the number of sequences originating from Italy as that's the maximum value and the most intensive colour.\r\n2. Even if we'd sum up all values from all countries shown, we wouldn't come to the amount of taxa in our tree/in a cluster because there are sequences for which we don't know the country of origin.\r\n\r\nLize on the other hand simply doesn't know which value is represented on the map, something we could add in the top right corner of the map for example?"}],"action":{"name":"View Issue","url":"https://github.com/rega-cev/phylogeotool/issues/17#issuecomment-297382310"}}}
Two new issues created #21 and #22
We need to mention what is visualised geographically