search

rega-cev / phylogeotool

4 stars 3 forks source link

Pplacer: entering non-FASTA format data #20

Closed GuyBaele closed 7 years ago

GuyBaele commented 7 years ago

When entering a simple text sequence (non-FASTA format), such as AAAACCCCTTTTGGGG, the sequence simply disappears when you try to enter an e-mail address, without any error or warning being presented to the user. So can some message be shown to the user?

Ewout1988 commented 7 years ago

Ok. I've tried it. There is a warning shown but we might want to make it more clear to the user. If I type 'AAAACCCCTTTTGGGG', I get the warning on the bottom: 'File format not recognised as fasta file'. Because it expects something like: '>1 AAAACCCCTTTTGGGG' Which is a fasta format.

Maybe showing the message in a red colour would be sufficient?

Ewout1988 commented 7 years ago

On top of this the original sequence that was typed should stay in the text box

GuyBaele commented 7 years ago

Yes, the typed sequence should stay in the box. Showing the message in red is also fine with me.

Ewout1988 commented 7 years ago

I've made some changes to the dialog box. Could we try to test all options again? In short. validity of all fields is now only checked when the user presses the 'Start' button. Not earlier and not later. When the text field had more than one sequence, a warning is shown that only the first sequence will be used.

GuyBaele commented 7 years ago

It's not very clearly communicated to the user what happens when multiple sequences in FASTA format have been provided. What I mean is, the user gets the message that only the first sequence will be used (after pressing Start) and then that window disappears. This might confuse people as to whether or not that first sequence has been submitted to pplacer. Perhaps add another sequence to the message that says 'You will receive an e-mail notification when the phylogenetic placement has been completed.' ?

Ewout1988 commented 7 years ago

Something like this?

screen shot 2017-04-28 at 13 23 09
GuyBaele commented 7 years ago

Works for me.

GuyBaele commented 7 years ago

Is it possible to switch the order in which the messages are shown to the user? So first show the message (in the case where the user submits multiple sequences) that only the first sequence will be used, and after that the message concerning the e-mail notification? At the moment, it's the other way around.

Ewout1988 commented 7 years ago

I'll make a seperate issue of this, which can be done after submission. Can we close this one in that case?