search

rega-cev / phylogeotool

4 stars 3 forks source link

Bar chart: Remaining bar is visible, even if it is empty. #4

Closed plibin closed 7 years ago

plibin commented 7 years ago

Do not show the Remaining column, unless there are values in it.

GuyBaele commented 7 years ago

Example?

Ewout1988 commented 7 years ago

There were indeed cases where this was true (e.g. http://phylogeotool.gbiomed.kuleuven.be/euresist/ , attribute="Gender"). I've updated the code and will push it with other changes later on.

screen shot 2017-04-25 at 15 51 41
GuyBaele commented 7 years ago

What about http://phylogeotool.gbiomed.kuleuven.be/dengue/, attribute="Serotype" ?

Ewout1988 commented 7 years ago

I have only updated the http://phylogeotool.gbiomed.kuleuven.be/euresist/ to the most recent version of the code such that I can more easily push new updates and see if they function instead of having to this for 4 different versions of the tool. At the end of the day, I'll remove the 2 instances that use Sgolay and keep only the other 2 (updated) online. Please don't test the new changes on the dengue instance. Sorry for the confusion.

GuyBaele commented 7 years ago

Can an update for dengue be pushed? It's mentioned in the paper, so it should work.

GuyBaele commented 7 years ago

Just tested the serotype issue with the latest dengue deployment and works fine.