Closed plibin closed 7 years ago
It's gonna be a lot easier to change the cluster color in that case. If you don't want black in can be some sort of grey? Give me the hexadecimal code of the color that you'd like and I'll change this.
Would it not be better to use some kind of palette rather than using a fixed vector of colours?
We want to indicate that they've reached the end of the clustering. That the cluster which is now currently coloured black is not clickable and is a leaf of the tree. If you'd use a palette of colours this information would get lost. In my opinion it's better to keep a specific colour to indicate that they're seeing an 'non-clickable' end of the clustering.
rgb(105,105,105) ?
nog dicht bij zwart eerder rgb(193, 191, 191)? On 25 Apr 2017, at 15:41, Guy Baele notifications@github.com<mailto:notifications@github.com> wrote:
rgb(105,105,105)
Please stick to using English. rgb (193,191,191) is fine by me.
I've changed it to rgb (193,191,191)
Looks good to me. Are you sure grey is not being used for colouring any of the other nodes?
I've got a list of colors that is being chosen for the colouring of the nodes
private static final String[] indexcolors = new String[]{
"#FF4A46", "#FFFF00", "#1CE6FF", "#FF34FF", "#008941", "#006FA6", "#A30059",
"#7A4900", "#ff1a92", "#0000A6", "#63FFAC", "#B79762", "#004D43", "#8FB0FF", "#997D87",
"#5A0007", "#809693", "#FEFFE6", "#1B4400", "#4FC601", "#3B5DFF", "#4A3B53", "#FF2F80",
"#61615A", "#BA0900", "#6B7900", "#00C2A0", "#FFAA92", "#FF90C9", "#B903AA", "#D16100",
"#DDEFFF", "#000035", "#7B4F4B", "#A1C299", "#300018", "#0AA6D8", "#013349", "#00846F",
"#372101", "#FFB500", "#C2FFED", "#A079BF", "#CC0744", "#C0B9B2", "#C2FF99", "#001E09",
"#00489C", "#6F0062", "#0CBD66", "#EEC3FF", "#456D75", "#B77B68", "#7A87A1", "#788D66",
"#885578", "#FAD09F", "#FF8A9A", "#D157A0", "#BEC459", "#456648", "#0086ED", "#886F4C",
"#34362D", "#B4A8BD", "#00A6AA", "#452C2C", "#636375", "#A3C8C9", "#FF913F", "#938A81",
"#575329", "#00FECF", "#B05B6F", "#8CD0FF", "#3B9700", "#04F757", "#C8A1A1", "#1E6E00",
"#7900D7", "#A77500", "#6367A9", "#A05837", "#6B002C", "#772600", "#D790FF", "#9B9700",
"#549E79", "#FFF69F", "#201625", "#72418F", "#BC23FF", "#99ADC0", "#3A2465", "#922329",
"#5B4534", "#FDE8DC", "#404E55", "#0089A3", "#CB7E98", "#A4E804", "#324E72", "#6A3A4C",
"#83AB58", "#001C1E", "#D1F7CE", "#004B28", "#C8D0F6", "#A3A489", "#806C66", "#222800",
"#BF5650", "#E83000", "#66796D", "#DA007C", "#FF1A59", "#8ADBB4", "#1E0200", "#5B4E51",
"#C895C5", "#320033", "#FF6832", "#66E1D3", "#CFCDAC", "#D0AC94", "#7ED379", "#012C58"
};
It always take colours starting from the beginning of the list. For example. If there are only 5 clusters (such as for example on: http://phylogeotool.gbiomed.kuleuven.be/euresist/), it takes
#FF4A46
#FFFF00
#1CE6FF
#FF34FF
#008941
If there are 15 nodes, it will take the following 15 colours:
#FF4A46
#FFFF00
#1CE6FF
#FF34FF
#008941
#006FA6
#A30059
#7A4900
#ff1a92
#0000A6
#63FFAC
#B79762
#004D43
#8FB0FF
#997D87
I'm not sure if any form of grey is in this list. For this, I should visualise all colours from the array.
OK looks good
Looks fine according to me. Close this issue then?
I will check an example in the tool when I arrive at the VUB, and if it works, I’ll close this issue.
These changes are not online. I'll put everything online together when other issues are fixed as well because otherwise I need to update 4 different war files every time a fix happens.
OK, but then we wait closing stuff, before we can actually test it
This seems to be working; can we close this issue?
Or if you like this, make the part of the tree dat no longer part of the clustering Grey.