search

rega-cev / phylogeotool

4 stars 3 forks source link

When exporting the tree, open a new tab. #8

Closed plibin closed 7 years ago

plibin commented 7 years ago

So when clicking on the "Download" link

Ewout1988 commented 7 years ago

This is now implemented.

GuyBaele commented 7 years ago

Great! Once that new window with the tree has been successfully opened, what should then happen in the main window? Should all windows that have to do with Exporting the tree be closed automatically?

Ewout1988 commented 7 years ago

It would not be a big problem to close those windows. It's whatever the preference is. We can close the 'Visualise Tree', 'Export Tree' and 'Confirmation' dialog after the 'Download' link was clicked. But maybe some users want to download another tree format (pdf, nexus, ...) after their previous download?

GuyBaele commented 7 years ago

I would suggest to only close the 'Confirmation' dialog, then the user can still select other export options. @plibin ?

plibin commented 7 years ago

Good idea!

Ewout1988 commented 7 years ago

This should be ok now

GuyBaele commented 7 years ago

Works fine for euresist, but needs to be deployed for dengue.