rega-cev / virulign

VIRULIGN: fast codon-correct alignment and annotation of viral genomes
GNU General Public License v2.0
29 stars 12 forks source link

Remove starting line from ORF10.xml of SARS-Cov-2 reference #17

Closed damianosmel closed 4 years ago

damianosmel commented 4 years ago

Thank you for developing this work. I have run some analysis using the virulign for SARS-Cov-2, using all ORF and NCBI target sequences. However the code would produce error when processing the ORF10 so I had to manually remove the first line of the ORF10.xml in order to have the code running.

Please check also but as solution I see to remove the first line in the ORF10.xml.

plibin commented 4 years ago

Hi Damianos,

On 13 May 2020, at 13:07, Damianos P. Melidis notifications@github.com<mailto:notifications@github.com> wrote:

Thank you for developing this work. I have run some analysis using the virulign for SARS-Cov-2, using all ORF and NCBI target sequences. However the code would produce error when processing the ORF10 so I had to manually remove the first line of the ORF10.xml in order to have the code running.

Please check also but as solution I see to remove the first linehttps://github.com/rega-cev/virulign/blob/10b9c7631e36223497335117dd50e4e5a60a1aa2/references/SARS-CoV-2/ORF10.xml#L1 in the ORF10.xml.

Sorry for this inconvenience, you’re completely right, I updated this, and pushed the fix.

Thanks a lot for your report and kind regards,

Pieter

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/rega-cev/virulign/issues/17, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJOXAQLVMECZ2SWUJMGVFTRRJ5PTANCNFSM4M7UXRWQ.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/rega-cev/virulign/issues/17", "url": "https://github.com/rega-cev/virulign/issues/17", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

damianosmel commented 4 years ago

Super Pieter, I will close the issue. Thank you very much!