search

regardscitoyens / the-law-factory-parser

Data generator for the-law-factory project
https://www.lafabriquedelaloi.fr
GNU General Public License v3.0
45 stars 9 forks source link

Fix Lois Dites broken on Legifrance #129

Open boogheta opened 3 years ago

mdamien commented 3 years ago

Since it doesn't look like this feature is coming back on legifrance, we could archive the last JSON in the repo and use it instead

boogheta commented 3 years ago

I understand they should add it somewhere in the opendata but yeah in the mean time archiving the json would make sense definitely !

mdamien commented 3 years ago

Hop, I have implemented that: https://github.com/regardscitoyens/the-law-factory-parser/commit/0692ed882716c02fc3504d873c7df57cb583db3f and f9dae82afc19bec00f7a5111e3c749693ab9920c

Looks like there's another problem, we use the JORFTEXTXXXX ID to match the text and it's name but we no longer have this ID in the URL

mdamien commented 3 years ago

My bad, the JORFTEXT ID is there on the new urls, ex: https://www.legifrance.gouv.fr/jorf/id/JORFTEXT000042219373

mdamien commented 3 years ago

We can say this bug is fixed I think, since the PR was merged

boogheta commented 3 years ago

Mmm no this was a temporary fix, but it froze the set, while lois dites are supposed to be included in the new legifrance as well and will still need to be handled