[WIP] Refactor amendments rendering without SVG nor d3

njoyard commented 8 years ago

This PR is a rewrite of #128 on the refactor-v2 branch.

It features a complete rewrite of the amendments rendering, no longer using d3 or svg. Rendering is done by AngularJS using the template, directly.

Finished :

[x] legend tooltips and clicks
[x] focus on a specific subject (either by click or by URL)
[x] use 2 columns when each line of amendments is less than half display width
[x] get rid of modules/mod2.js after ensuring that no one else uses it
[x] restore help text on right pane
[x] check https compatibility
[x] remove bogus government code
[x] ~~add title slug to subject classes (see here and here) and~~ restore scrolltop
[x] restore first-art[-s] classes and ensure tutorial is working

Todo:

[x] implement a snake-like arrangement of amendments (except when using the new ordering by number since it would break its meaning then :) )
[x] add auto-refresh (new feature)
[x] check that rendering is consistent across browsers
[x] restore missing date when displaying amdt content
[x] fix date format in amdt tooltip
[x] truncate article background to display a round number of squares
[x] cross-fade amdt content (hide -> spinner -> show)
[x] fix wrong tooltip positioning (scroll-dependent)
[x] never use 2-column mode when grouped
[x] keyboard navigation for amdt content
[x] display first author in popover cf https://github.com/regardscitoyens/the-law-factory/commit/d258a24d2d0095f0a199dd964dc24100cf7e1d4c

Postponed :

[x] ~~rename "mod2" occurences everywhere (templates/mod2.html & setMod2Size at least)~~ in a future PR

Comments welcome, angularjs newbie here :P

fmassot commented 8 years ago

Now that all mod2 is in a directive, I would isolate this directive in a separate file. Maybe in modules/mod2-directive.js ?

njoyard commented 8 years ago

As discussed on irc, directive isolation/renaming will be done in a future PR.

Did some more work and rebased on the tip of the branch. I also updated the PR description with a to-do list. Very close to being finished \o/

RouxRC commented 8 years ago

RouxRC commented 8 years ago

On avait aussi des classes first-art et first-art-s pour les premiers de chaque, mais pas sûr de voir si et à quoi elles servaient.

RouxRC commented 8 years ago

and FYI, I allowed myself to add a few comments within the todo list above ;)

njoyard commented 8 years ago

Attention à l'ordering des sujets des amendements

Sinon pour gérer le clic sur les légendes

Legend click should do something? Does not seem to do anything on prod (or maybe not with all laws?)

On avait aussi des classes first-art et first-art-s

Yeah, I missed that. They're used by the tutorial.

rename "mod2" occurences everywhere (templates/mod2.html & setMod2Size at least)

As discussed with @fmassot, this will be in a future PR that reorganizes all modX directives

RouxRC commented 8 years ago

mmm indeed for the subject sorting, my bad (changed your pointer link which didn't seem correspondign though ;) )
Yes, legends are clickable to highlight (this was the name of the function called) only related amendments. Are you deving on Firefox? My recalls are it was only working under webkit (which was weird by the way, see #115 ) but yes, it is supposed to grey all other amendments than the selected choice, explaining also the need for the click background part to deactivate any selection
And by the way, while we're at it, for legends tooltips, issue #119 should be taken into account

and attaching #106 as well here

njoyard commented 8 years ago

Okay, I'll reimplement that then. And github is weird with links to lines of code sometimes...

regardscitoyens / the-law-factory