njoyard
commented
8 years ago FYI I pushed 3 working solutions on my fork. They all have the same visual result but different performance. To help testing I removed the 2-column mode and some container sizing is not quite right but that's not what matters right now, all this will be fixed.
From worst to best performance:
- snake-columns: puts amendments in column containers (vertical flex, every other one has reversed direction using css)
- snake-pos: gives absolute coordinates to each amendment
- snake-swap: keeps all amendments in a single container (a flex container flowing in columns with a fixed height computed form amendment count) but swaps items in the amendment array before passing them to angular (so that a 3 line subject will have amdts 0 1 2 5 4 3 6 7 8 11 10 9 ...)
Feel free to tell me what you think about those. In all 3 cases performance is a bit hurt by the fact that we have a huge number of angular watchers (ng-repeat on subjects > ng-repeat on amendments > many dynamic properties). So I was wondering, given that we tell angular to identify amendments by their id_api, can we assume that a bunch of properties will never change on a given amendment (amdt number, group, title, authors for example) ? That would allow using one-time binding (ie. {{ ::value }}) and only use dynamic binding for things that do change (such as amendment status).
What do you think @fmassot @RouxRC ?
fmassot
RouxRC
Lost when merging #129