Handle keypress up/down in amendments

regardscitoyens / the-law-factory

Track the french law-making process

https://www.lafabriquedelaloi.fr

GNU Affero General Public License v3.0

76 stars 15 forks source link

Handle keypress up/down in amendments #142

Closed RouxRC closed 8 years ago

RouxRC commented 8 years ago

Should handle the length of lines to know where to go when multiline
Should allow to switch from on esubject to another, aligning vertically or to the maximum right if currently further
This is going to be a happy mess to handle with the snake ordering added :)

njoyard commented 8 years ago

Actually I think snake ordering will make this easier, because we'll have to know where each amendment is displayed. Linking #131 here for reference :)

njoyard commented 8 years ago

There might still be an issue when in two column mode, I'll fix that tomorrow morning.

njoyard commented 8 years ago

All clear :)

boogheta commented 8 years ago

currently can't test it locally because of the weird crossdomains issues discussed on irc

RouxRC commented 8 years ago

Works great! including with the snake and multicolulm, really cool :)

Although I still see two minor fixes :)

The first one is not directly related to the keypress but rather to the multicolumn so i posted a dedicated issue #162

The second one is that when moving up/down it would be best if the viz view would also scroll accordingly so that the selected amendment always remains visible, same way as in the articles view or when getting to an amendments page with a subject