search

regardscitoyens / the-law-factory

Track the french law-making process
https://www.lafabriquedelaloi.fr
GNU Affero General Public License v3.0
75 stars 15 forks source link

drop resize stuff #152

Closed fmassot closed 8 years ago

fmassot commented 8 years ago

There are way too many calls of resize function in this app, we should drop that and just let the browser make this for us ! As @njoyard suggest, we can for example just use absolute positioning.

RouxRC commented 8 years ago

are we speaking only about amendments or everywhere ? :)

njoyard commented 8 years ago

Everywhere. Page layout is nearly the same in all modules.

RouxRC commented 8 years ago

go for it! just beware the probably numberous pieces of d3 that deal with sizes :)

njoyard commented 8 years ago

Progress can be followed on my new-stylesheet branch.

Note that in the end only the compiled CSS will be versioned and the branch will be rebased to separate commits into more targeted changes.

RouxRC commented 8 years ago

@fmassot I guess this is closable now with css-refacto, except if you meant also dropping the resize watches that are used to redraw the svgs?

fmassot commented 8 years ago

nope the refacto is just perfect !