Closed njoyard closed 8 years ago
Haven't looked at everything yet, but here are two first regressions spotted:
Fixed those, additionnaly there's a running instance of this branch available here: https://lfdl-njoyard.rhcloud.com/
first seen issues
@fmassot fixed as of 82903a3
Remaining issues :
Some more things :
Couple more things relative to the legends in amendments and debates:
and adding below newly discovered things ;)
Fixed most of those, except:
And sorry, just found one more:
I don't think cloaks could counteract each other (it's just a [ng-cloak] { display: none !important; }
rule), unless there is somple display: *not none* !important;
somewhere, which may be the case in bootstrap css. I'll have a look :)
Remaining:
I feel like these two are not critic and can be handled outside of this PR which we should nearly be able to merge (still want to finish rereading the latest commits but then I feel like merging :) ). The first one could be a separate issue to handle later as we do not advertise the keyboard yet in debates, so people shouldn't complain that something unexpected isn't there ;) I'll add it later The second one is actually the opposite IMHO and is listed already in #154
Good for me, agreed :)
All right everything reviewed and other issues created My last step is to test out the various makefile entries in local tomorrow and then we merge! @fmassot last chance to report anything else ;)
I removed new features that I previously added to this PR (JSON-configurable home & colorblind mode) to ease merging.
Those features are in a separate local branch for now, they'll each live in a separate PR when this gets merged ;)
This PR switches to absolute positioning for modules, gets rid of sperfluous html markup and enables simpler resize logic.
Warning: for some reason GitHub displays commits below in the wrong order (probably because some of them were created by a rebase at the exact same time). See the css-refactor branch this PR was created from for the "real" order.
Fixes #152.