Stylesheet refactor - Githubissues

njoyard commented 8 years ago

This PR switches to absolute positioning for modules, gets rid of sperfluous html markup and enables simpler resize logic.

Warning: for some reason GitHub displays commits below in the wrong order (probably because some of them were created by a rebase at the exact same time). See the css-refactor branch this PR was created from for the "real" order.

Fixes #152.

RouxRC commented 8 years ago

Haven't looked at everything yet, but here are two first regressions spotted:

In Articles view, when an article is selected, in no diff mode, alineas should use ol instead of li to mark the number of each alinea
In the stepsbar when in amendments or interventions view, the marker should be clearly selected when clicked, now it just disappears as for steps not having it

njoyard commented 8 years ago

Fixed those, additionnaly there's a running instance of this branch available here: https://lfdl-njoyard.rhcloud.com/

fmassot commented 8 years ago

first seen issues

colors of class "stb-inst deputes", "stb-inst assemblee", "stb-inst senat"... are broken in stepbar
on articles view, no cursor pointer on article
on articles view, in the article diff panel, there is no more numerotation of alineas
color of the text of article in the diff panel is not green

njoyard commented 8 years ago

@fmassot fixed as of 82903a3

njoyard commented 8 years ago

Remaining issues :

~~stepsbar : current tab is no longer highlighted (bright background)~~ fixed by 40b67f6
~~stepsbar : link icon is too dark, add some transparency~~ fixed by e34fbeb

boogheta commented 8 years ago

Some more things :

[x] Homepage : the divs that link to specific texts should be completely clickable and not only the textual part
[x] Stepsbar : handle a:hover on link icons (issue appears for live texts on amendments links having a space next to it appear underlined)
[x] Amendments sidebar : the square icon is too small in height (so not squared) making the icon inside uncentered (on chromium at least)
[x] Lois/Articles sidebar : the link button to articles/amendments used to have a slightly bigger font, I believe it was useful to help make these more visible, I feel like they are more discrete now
[x] Search zone : give it more width ?

RouxRC commented 8 years ago

Couple more things relative to the legends in amendments and debates:

[x] in amendments selecting the status elements works but shades the selected legend along with the others

~~[x] in debates strangely the blank space around a legend element shows the hand cursor but does not activate when clicked (in amendments it behaves properly)~~

~~[ ] in debates as well clicking on the background div of the legend when a legend selection is active should deactivate it as when clicking on the viz background (in amendments it does)~~

and adding below newly discovered things ;)

[x] ng-cloak seems missing on the stepsbar and the menu bar (i saw angular variables on articles view in the stepsbar, and on amendments in the group/sort menu)

njoyard commented 8 years ago

Fixed most of those, except:

cloaks missing on menu: didn't find any, if you find something reproducible...
debates legend deselection: this is already the case in production, i'd rather rewrite a legend factorization as stated in #154 :)

boogheta commented 8 years ago

regarding cloaks those I saw were these ones https://github.com/regardscitoyens/the-law-factory/blob/60333699ceffc3d2abaa178f2f7f5c65c287dff7/public/modules/amendements/amendements.html#L5-L16 but indeed they're already cloaked so I don't know... :/ Although they are double cloaked (the nav on top also have it) could it be they're counteracting? I know it's hard to reproduce these bugs as they only happen when js is loaded a bit slowly :/
for the debates legends, your fix actually makes it inconsistent with amendments (which have the proper behavior IMO) but I'll move the debates legends problems to a separate issue as the refacto shouldn't depend on these

And sorry, just found one more:

[x] in amendments the empty legend div between government and statuses has a hand cursor whch is confusing since it ain't clickable

njoyard commented 8 years ago

I don't think cloaks could counteract each other (it's just a [ng-cloak] { display: none !important; } rule), unless there is somple display: *not none* !important; somewhere, which may be the case in bootstrap css. I'll have a look :)

njoyard commented 8 years ago

Remaining:

[ ] key controls in debats don't work on webkit

[ ] legend clickable zone too large in debats

boogheta commented 8 years ago

I feel like these two are not critic and can be handled outside of this PR which we should nearly be able to merge (still want to finish rereading the latest commits but then I feel like merging :) ). The first one could be a separate issue to handle later as we do not advertise the keyboard yet in debates, so people shouldn't complain that something unexpected isn't there ;) I'll add it later The second one is actually the opposite IMHO and is listed already in #154

njoyard commented 8 years ago

Good for me, agreed :)

boogheta commented 8 years ago

All right everything reviewed and other issues created My last step is to test out the various makefile entries in local tomorrow and then we merge! @fmassot last chance to report anything else ;)

njoyard commented 8 years ago

I removed new features that I previously added to this PR (JSON-configurable home & colorblind mode) to ease merging.

Those features are in a separate local branch for now, they'll each live in a separate PR when this gets merged ;)

regardscitoyens / the-law-factory

Stylesheet refactor #165