[StepsBar] Resize could adjust steps name as before

regardscitoyens / the-law-factory

Track the french law-making process

https://www.lafabriquedelaloi.fr

GNU Affero General Public License v3.0

75 stars 15 forks source link

[StepsBar] Resize could adjust steps name as before #185

Closed RouxRC closed 8 years ago

RouxRC commented 8 years ago

When it was spying resizes it was also adjusting to the short names of each steps when necessary, we could have those names as conditional angular variables depending on a watch resize maybe?

njoyard commented 8 years ago

I think we can do that with CSS only, I'll give it a try.

RouxRC commented 8 years ago

reopening to point out two comments

https://github.com/regardscitoyens/the-law-factory/commit/085e3dfee9e290ac2e9ba1a8ec304267ead433b0#commitcomment-17392382
https://github.com/regardscitoyens/the-law-factory/commit/085e3dfee9e290ac2e9ba1a8ec304267ead433b0#commitcomment-17392371

njoyard commented 8 years ago

I just realized that, but we could have used CSS text-overflow instead of that. The downside being that it does not allow to control how text is shortened (so we would have had "Ass..." and "Comm...").

RouxRC commented 8 years ago

yeah I'd rather have more code but more explicit acronyms :)