search

regebro / hovercraft

Make dynamic impressive presentations from text files!
https://hovercraft.readthedocs.org
MIT License
1.49k stars 208 forks source link

Add new template with Impress 1.0.0 #170

Closed ccamara closed 6 years ago

ccamara commented 6 years ago

As per issue #154 I have created a rough attempt to add the new toolbar.

Since I am not very confident on my skills nor familiarized with hovercraft yet, and In order not to break things, I created a new template with impress.js 1.0.0 and the toolbar, so in order to test this PR hovercraft should call this new template: hovercraft <filename.rst> --template=templates/impress1.0.0

ccamara commented 6 years ago

@regebro , I've rebased this PR with latest repo's updates and after b57a36d checks are passing as well. You may want to merge this PR or make comments to it.

tonysyu commented 6 years ago

@ccamara: The example command doesn't work for me, but I might be doing something wrong. When I run hovercraft <filename.rst> --template=templates/impress1.0.0, hovercraft looks for a template at [CURRENT WORKING DIRECTORY]/templates/impress1.0.0 rather than sourcing the template from the hovercraft install. Not sure if that's expected, but I didn't realize that when reading the PR description.

tonysyu commented 6 years ago

I also noticed that this seems to break the goto-slide functionality

regebro commented 6 years ago

Hi, thanks for this! I've looked at it and used some bits in my branch, but ultimately I got confused by the big changes, so I decided to do it step by step myself so I understand what is going on, even though this of course mostly means doing what you did, albeit perhaps in a different order.

But just because I'm not merging this branch, don't think it wasn't useful! (I added @ccamara to the contributors list.)

1.0.0 seems backwards compatible enough so that it doesn't break the examples, so I'm updating the standard templates instead of making a new one, I guess that's the major difference.

ccamara commented 6 years ago

Glad to see this implemented and glad that my contribution was helpful.

Regards

On Sun, Oct 7, 2018 at 10:59 AM Lennart Regebro notifications@github.com wrote:

Hi, thanks for this! I've looked at it and used some bits in my branch, but ultimately I got confused by the big changes, so I decided to do it step by step myself so I understand what is going on, even though this of course mostly means doing what you did, albeit perhaps in a different order.

But just because I'm not merging this branch, don't think it wasn't useful!

1.0.0 seems backwards compatible enough so that it doesn't break the examples, so I'm updating the standard templates instead of making a new one, I guess that's the major difference.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regebro/hovercraft/pull/170#issuecomment-427637138, or mute the thread https://github.com/notifications/unsubscribe-auth/AArH9fd26xNvWiIrh6eL2MzqwdIniY9uks5uicJsgaJpZM4ViEpj .