search

regen-network / indexer

:rocket: Blockchain indexer and database
Other
2 stars 0 forks source link

fix: run checks on pushes to any branch #48

Closed wgwz closed 1 year ago

wgwz commented 1 year ago

@ryanchristo i noticed in the current PR i'm working on that the checks did not get run for a new commit that i pushed. i copied a line of configuration from the workflow in regen-server. and i think this change could fix that. it says "run ci checks on pushes to any branch"

wgwz commented 1 year ago

@ryanchristo i think we could also remove the configuration for "pull requests". we don't have that line in the regen-server and it seems to always satisfy our expectations there. every PR always has the checks being run. WDYT?

ryanchristo commented 1 year ago

~The current settings without changes is the ideal behavior as far as I understand and~ these changes make the tests run twice:

image

Maybe we should just remove the pull request setting if we want to run on every commit?

wgwz commented 1 year ago

I'm not sure I understand why we would want to run the github action twice per pull request into main (one because of the updated branches setting and the other because of the pull request setting).

i just wasn't sure if you had a preference either way

wgwz commented 1 year ago

~The current settings without changes is the ideal behavior as far as I understand and~ these changes make the tests run twice:

image

Maybe we should just remove the pull request setting if we want to run on every commit?

that's why i said this before 👇

i think we could also remove the configuration for "pull requests"

i was just asking what you thought in case there was a preference for using the on pull request setting over the on push setting

anyways, will remove the pull request setting!

ryanchristo commented 1 year ago

Yea, my misunderstanding. All commits and pull request setting removed sounds like a good idea.