regen-network / regen-ledger

:seedling: Blockchain for planetary regeneration
https://docs.regen.network
Other
214 stars 103 forks source link

Address empty in version when registering an account #1706

Open ryanchristo opened 1 year ago

ryanchristo commented 1 year ago

Summary of Bug

While testing the intertx module, I was running into a key not found error after registering an ica account with tx intertx register and then querying for the account with q intertx ica.

The transaction is successful but I noticed in the transaction address was not being populated within version and manually passing the --version flag with tx intertx register that includes the address resolved the issue.

We should further investigate why address is not being included in version and ideally this would be automatically populated and passing the --version flag with tx intertx register would not be required.

Version

release/v5.0.x

Steps to Reproduce

See https://hackmd.io/L4Ru-CeuQZ6VMMrBXYDHLA

The address in version is not populated:

regen tx intertx register --from $WALLET_3 --connection-id connection-0 --home ./data/regen-ica
{"fee_version":"ics29-1","app_version":"{\"version\":\"ics27-1\",\"controller_connection_id\":\"connection-0\",\"host_connection_id\":\"connection-0\",\"address\":\"\",\"encoding\":\"proto3\",\"tx_type\":\"sdk_multi_msg\"}"}

The address in version is manually set and the account can be queried:

regen tx intertx register --from $WALLET_3 --connection-id connection-0  --version '{"version":"ics27-1","tx_type":"sdk_multi_msg","encoding":"proto3","host_connection_id":"connection-0","controller_connection_id":"connection-0","address":"regen14zs2x38lmkw4eqvl3lpml5l8crzaxn6mpvh79z"}' --home ./data/regen-ica
regen q intertx ica $WALLET_3 connection-0

For Admin Use


For Admin Use

ryanchristo commented 1 year ago

This would be a non-api or state breaking change to resolve and therefore we can resolve following the v5.0 release.