Hi @blushi and @S4mmyb , I just wanted to open up a PR for Sam's branch so we can review. I actually think we should close this in favor of continuing the review process over in my PR #12 . I think Sam based his branch off of mine, so I've merged Sam's changes into my branch successfully and I also took care of the merge conflicts that both Sam's branch and my branch had with main. So I think it might make sense to just continue on in my PR and close this out. I just wanted to open it anyways in case I'm not understanding why it might be better separate.
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
[x] provided a link to the relevant issue or specification
[x] reviewed "Files changed" and left comments if necessary
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
[ ] confirmed all author checklist items have been addressed
blushi
commented
2 years ago
Description
Closes: https://github.com/regen-network/regen-registry/issues/780
Hi @blushi and @S4mmyb , I just wanted to open up a PR for Sam's branch so we can review. I actually think we should close this in favor of continuing the review process over in my PR #12 . I think Sam based his branch off of mine, so I've merged Sam's changes into my branch successfully and I also took care of the merge conflicts that both Sam's branch and my branch had with
main. So I think it might make sense to just continue on in my PR and close this out. I just wanted to open it anyways in case I'm not understanding why it might be better separate.The relevant files for Sam's changes are:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...