credit class metadata for fibershed credit class

S4mmyb commented 11 months ago

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

[ ] provided a link to the relevant issue or specification
[ ] reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

[ ] confirmed all author checklist items have been addressed
[ ] reviewed code correctness and readability
[ ] reviewed documentation is accurate
[ ] manually tested (if applicable)

wgwz commented 10 months ago

@blushi i was just looking at the ci check for this PR and it looks like we might have some field in the common credit class file that needs to marked as optional? not 100% sure that's what's going on but just wanted to flag it.

shapes=/tmp/tmpkh85egq6.ttl data=jsonld/C03/project-metadata/C03-project-full-example.jsonld result=ERROR
org.apache.jena.shacl.parser.ShaclParseException: Missing property shape: node=_:Bf57badc002b17e27a20492cee90c4874 sh:property <[https://schema.regen.network#creditGenerationMethodPropertyShape](https://schema.regen.network/#creditGenerationMethodPropertyShape)>

blushi commented 10 months ago

@blushi i was just looking at the ci check for this PR and it looks like we might have some field in the common credit class file that needs to marked as optional? not 100% sure that's what's going on but just wanted to flag it.
shapes=/tmp/tmpkh85egq6.ttl data=jsonld/C03/project-metadata/C03-project-full-example.jsonld result=ERROR
org.apache.jena.shacl.parser.ShaclParseException: Missing property shape: node=_:Bf57badc002b17e27a20492cee90c4874 sh:property <[https://schema.regen.network#creditGenerationMethodPropertyShape](https://schema.regen.network/#creditGenerationMethodPropertyShape)>

There's a follow-up issue about moving properties to the generic credit class ttl and making some of them optional: https://github.com/regen-network/regen-registry-standards/issues/70 In the mean time, I fixed the missing property issue (just a typo).

regen-network / regen-registry-standards