regen-network / regen-server

:seedling: Regen web server and database
https://api.regen.network
6 stars 5 forks source link

fix: web3 account google login with email already used as main email by another account #431

Closed blushi closed 5 months ago

blushi commented 6 months ago

Description

Closes: #425


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

blushi commented 5 months ago

I'm confused as to why we want to allow this. If someone has account A with that email, why should we let them connect to a different web3 account with the same email but via google instead of email? This seems like something we should disallow.

This is just a consequence of the fact that we let users have a google email that could be different from the main email (used for logging in via OTP) cc/ @erikalogie

blushi commented 5 months ago

closing per discussion during the architecture call, we should instead have uniqueness across Google email and main email and when connecting to google, set main email to google email.