regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Project Tab Page (Ledger Integration) #1055

Closed S4mmyb closed 2 years ago

S4mmyb commented 2 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Query project data

Describe the solution you'd like A clear and concise description of what you want to happen. This can follow a user story template: As a _, when I __, I would like ____ .

Describe alternatives you've considered (optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context (optional) Add any other context, screenshots or figma links about the feature request here.


For Admin Use

mhagel commented 2 years ago

Please add your planning poker estimate with ZenHub @haveanicedavid

mhagel commented 2 years ago

@erikalogie ready for feedback: https://deploy-preview-1140--regen-registry.netlify.app/projects

mhagel commented 2 years ago

@erikalogie ICYMI, ready for feedback. https://deploy-preview-1140--regen-registry.netlify.app/projects

How to test

  1. Create sell orders if needed (some with Disable Auto Retire)
  2. Change accounts and go to /projects
  3. Buy sell orders from this page

Optional: try creating and buying sell orders with odd prices (lots of decimals, big or small amounts)

Also note, I added sell-order transactions to the Activity table,

erikalogie commented 2 years ago

I think that the default for the filter should be price high to low just so you see the projects with sell orders first.

I can't get a transaction to go through because of this error: https://monosnap.com/file/7KGWP3jVPvDqhasyUMoDAESPV0Fjt7

erikalogie commented 2 years ago

Actually I think it is because I don't have any REGEN on my other test account. I tried to send some from this address: regen1df675r9vnf7pdedn4sf26svdsem3ugavgxmy46 to this address regen1axf5u6wj0tut6vs5w46krycs00k9lwmxyr7l9v but the transaction failed. How can I get some REGEN on the v4 testnet on this other account to test the buying flow?

mhagel commented 2 years ago

Our deploy previews are pointing at redwood now. I got you some REGEN from the faucet. If you need more in the future go here http://209.182.218.23:8000/faucet/regen1axf5u6wj0tut6vs5w46krycs00k9lwmxyr7l9v

mhagel commented 2 years ago

I think that the default for the filter should be price high to low just so you see the projects with sell orders first.

Ok. Or maybe I can adjust the low-to-high filters to put zero-credit-projects at the end.

erikalogie commented 2 years ago

I think that the default for the filter should be price high to low just so you see the projects with sell orders first.

Ok. Or maybe I can adjust the low-to-high filters to put zero-credit-projects at the end.

Yes this is a good idea

erikalogie commented 2 years ago

Our deploy previews are pointing at redwood now. I got you some REGEN from the faucet. If you need more in the future go here http://209.182.218.23:8000/faucet/regen1axf5u6wj0tut6vs5w46krycs00k9lwmxyr7l9v

Thanks! Now I'm getting this error on sell order #4 on the deploy preview link when trying to purchase using "retire credits manually" from the Projects page: https://monosnap.com/file/qEgMqKOF6NaO20J1YSamOS1kc7tVFJ

mhagel commented 2 years ago

Ready for another look @erikalogie

For the Peachtree Hill project, I added some sell orders with disable-auto-retire (15 REGEN), and some without (44 REGEN).

Also updated sorting.

https://deploy-preview-1140--regen-registry.netlify.app/projects

S4mmyb commented 2 years ago

@mhagel I think this looks good - one thing we might want to note is that users can currently input a higher amount of credits than those available. In the future we might want to implement a max feature which bounds the # of credits they can input. Otherwise looks great!

mhagel commented 2 years ago

one thing we might want to note is that users can currently input a higher amount of credits than those available

@S4mmyb

Good catch. The max bound works if you click the button to increment, but not if you type a bigger amount. I created a bug so we can move this forward: https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-web/1164

erikalogie commented 2 years ago

This looks good! Great work.