search

regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

[web-components] Seller can fill out basic Organization Profile page after completion of user profile #332

Closed erikalogie closed 3 years ago

erikalogie commented 3 years ago

Mobile version: https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=3856%3A410 Desktop version: https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=3883%3A71767

This same component is used later in the add project flow to create a new organizational entity to identify the land steward, project developer, or land owner if they are an organization as opposed to an individual. So parts of this should be reusable for this popup: https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=4041%3A1755

The edit version of this component will be accessible via the user menu, and will look like this: https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=4088%3A2595

NB: This issue is just about building the react components (without wiring them up in the registry app #352)

erikalogie commented 3 years ago

https://deploy-preview-469--regen-storybook.netlify.app/?path=/story/components-forms--user-profile

erikalogie commented 3 years ago

Some feedback @haveanicedavid: https://monosnap.com/file/ht68S6V2DGLzYJmFPD4ZOwU0WE19mN https://monosnap.com/file/tBZhb36HMiOqNMNAOXBANXo1DamvIr

The biggest issue that I see is that the spacing in the phone number field does not change correctly depending on the country selected. It would probably be best if we just get rid of the spacing altogether if there isn't a quick fix for this within this component settings because otherwise it is quite confusing when using non-US formatted phone numbers.

Also, we don't need a phone number on the org profile, but same comments apply to the user profile.

haveanicedavid commented 3 years ago

@erikalogie I think I addressed all of these, but let me know if I need to tweak the sizing / position any further. I also wired up the image component, so you can test that out

The location search will be connected shortly

erikalogie commented 3 years ago

This is getting really close.

It would be great if you could make the organization logo optional.

Also, this padding in the description field is a bit strange: https://monosnap.com/file/ZaU7pOam1zLDvAegpFHcY4vGf7Avtk. Would be ideal if the scroll bars were all the way on the right and extended all the way to the top and bottom of the box. Also if the text didn't get cut off 10px below and above the top and bottom of the box.

Otherwise, looks good!

On Thu, Feb 18, 2021 at 2:24 PM David Daniel notifications@github.com wrote:

@erikalogie https://github.com/erikalogie I think I addressed all of these, but let me know if I need to tweak the sizing / position any further. I also wired up the image component, so you can test that out

The location search will be connected shortly

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/332#issuecomment-781545118, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTLFPYPMD77DYMW3R3TS7VLNLANCNFSM4W7IPAIA .

erikalogie commented 3 years ago

One thing I just noticed is that the user should be able to delete the image as well as upload a new one. You'll see that in the UI. Less important for this specific application in the user profile/org profile, but for the photos in the media section for example it is important that they can delete them too. @mhagel maybe this is more on your end, not sure what the split is here between you guys.

On Thu, Feb 18, 2021 at 7:44 PM Erika Logie erika.logie@gmail.com wrote:

This is getting really close.

It would be great if you could make the organization logo optional.

Also, this padding in the description field is a bit strange: https://monosnap.com/file/ZaU7pOam1zLDvAegpFHcY4vGf7Avtk. Would be ideal if the scroll bars were all the way on the right and extended all the way to the top and bottom of the box. Also if the text didn't get cut off 10px below and above the top and bottom of the box.

Otherwise, looks good!

On Thu, Feb 18, 2021 at 2:24 PM David Daniel notifications@github.com wrote:

@erikalogie https://github.com/erikalogie I think I addressed all of these, but let me know if I need to tweak the sizing / position any further. I also wired up the image component, so you can test that out

The location search will be connected shortly

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/332#issuecomment-781545118, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTLFPYPMD77DYMW3R3TS7VLNLANCNFSM4W7IPAIA .