Closed erikalogie closed 3 years ago
Planning notes:
Share session feedback
Demo feedback:
@erikalogie @rsteinhe Ready to review at https://deploy-preview-601--regen-registry.netlify.app/projects/wilmot
I have only added documents data for Wilmot so far. If this looks good, I'll continue with the rest.
cc @blushi
One small desktop issue: https://monosnap.com/file/UyQ16X4VdGfWlyJVMogL6IpVo5E6TL
Some small mobile issues: https://monosnap.com/file/k6SHKJiXJLd2TRjE2r80n72mEmPScI https://monosnap.com/file/XOaoWz2ZIXBdGCoilKqdu1pjRCWERD https://monosnap.com/file/tvogRuJZd3KYSlXlbKy1uG0t7KUQvw https://monosnap.com/file/5ArFX2W4IeZiP18oq6WFx6qF1iHiwy https://monosnap.com/file/FlX2zhBbtBzGrmENHPKASnh7FdxHKd https://monosnap.com/file/QlpZasl2YXzVEEIc5Y2Qi9csh3HMFL
On Tue, May 11, 2021 at 2:13 PM Mark Hagelberg @.***> wrote:
@erikalogie https://github.com/erikalogie @rsteinhe https://github.com/rsteinhe Ready to review at https://deploy-preview-601--regen-registry.netlify.app/projects/wilmot
I have only added documents data for Wilmot so far. If this looks good, I'll continue with the rest.
cc @blushi https://github.com/blushi
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/408#issuecomment-838937391, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTNIGKWJ4V35MQQ6ORLTNFXWNANCNFSM4ZK5R2ZQ .
@erikalogie Fixes are deploying.
For https://monosnap.com/file/XOaoWz2ZIXBdGCoilKqdu1pjRCWERD (sticky table header cell)...
This is a quirk of the fixed header that allows the rows below to scroll up and down. I noticed the same behavior in Material-UI's demo. I don't see a way around it yet if we want the fixed table header. The good news is that it does scroll out of the way when the column below does.
Hopefully we can live with this for now, since it is non-blocking? Otherwise, we can rethink the fixed header, make a new issue, or I can keep searching for a hack to deal with it.
Ok, yeah don't worry about the fixed header.
Just a couple of more small spacing tweaks: https://monosnap.com/file/9mpjlsarhuLPkVzMCdK3wJA7hg3XeT
On Wed, May 12, 2021 at 7:37 AM Mark Hagelberg @.***> wrote:
@erikalogie https://github.com/erikalogie Fixes are deploying.
For https://monosnap.com/file/XOaoWz2ZIXBdGCoilKqdu1pjRCWERD (sticky table header cell)...
This is a quirk of the fixed header that allows the rows below to scroll up and down. I noticed the same behavior in Material-UI's demo https://material-ui.com/components/tables/#collapsible-table. I don't see a way around it yet if we want the fixed table header. The good news is that it does scroll out of the way when the column below does.
Hopefully we can live with this for now, since it is non-blocking? Otherwise, we can rethink the fixed header, make a new issue, or I can keep searching for a hack to deal with it.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/408#issuecomment-839700703, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTM2DL4AQ3WTSTJTGATTNJR67ANCNFSM4ZK5R2ZQ .
@erikalogie
Just a couple of more small spacing tweaks
Done.
Sorry, just one small spacing tweak and we should be done here: https://monosnap.com/file/IRuHbUSDtahxVXCiCypX6fu1eqGzt1
This looks great now! It is ready to go from my perspective.
On Fri, May 14, 2021 at 12:54 PM Mark Hagelberg @.***> wrote:
@erikalogie https://github.com/erikalogie NP! https://deploy-preview-601--regen-registry.netlify.app/projects/wilmot
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/408#issuecomment-841370970, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTPZKE6N6UNWGEIRBYLTNVITPANCNFSM4ZK5R2ZQ .
Desktop version: https://www.figma.com/file/bY5PBiij1nAdafyshCMvXr/New-Project-Page-Design-for-Wilmot-and-Other-Impact-Ag-Projects?node-id=1043%3A1
Mobile version: https://www.figma.com/file/bY5PBiij1nAdafyshCMvXr/New-Project-Page-Design-for-Wilmot-and-Other-Impact-Ag-Projects?node-id=1147%3A0
Changes to implement: