search

regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Create Project Plan: Eligibility: Additionality [UI only] #420

Closed blushi closed 3 years ago

blushi commented 3 years ago

See this comment for more info on UX / required fields: https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL?node-id=4980:10218#69754071

mobile: https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=4980%3A10218 and https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=4980%3A10248

desktop: https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=5064%3A16780 and https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=5091%3A1362

erikalogie commented 3 years ago

@haveanicedavid just FYI I just had a meeting with Ron and talked about changing the name of this screen to "Eligibility: Additionality". I'm going to change it in the comps

haveanicedavid commented 3 years ago

@erikalogie ready for review: https://deploy-preview-604--regen-registry.netlify.app/project-plans/eligibility

haveanicedavid commented 3 years ago

@erikalogie I'll also need content / copy for the hover icons on the first section

erikalogie commented 3 years ago

Small tweaks on mobile: https://monosnap.com/file/D0vKpN0YGIUJu4Nou56aHbN9i4xP23

Also, check out this design comp for this component combined with the calendar, as the spacing between "choose a practice date" and the input field looks a bit too big and the font size for "choose a practice date" is also too big https://www.figma.com/file/MuSpCtCdU2ns4cFAsPfvsx/Text-Styles-and-Components-current?node-id=4310%3A0 .

The tooltips don't seem to work on mobile.

If possible, it would be nice if this whole section were the hit state, this is especially relevant on mobile: https://monosnap.com/file/vB0pCnO6l6YgbxRBecb90biEmoxTux.

I've asked Sam for the copy for the tooltips

On Tue, May 11, 2021 at 12:30 PM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie I'll also need content / copy for the hover icons on the first section

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/420#issuecomment-838789621, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTM545GGTZNUOFAVI7TTNFLRFANCNFSM42BYGLRQ .

haveanicedavid commented 3 years ago

@erikalogie I think I addressed most of what you brought up. Appreciate your eye here - sometimes modifying one value has some side effects that are hard to catch. Once we get the first few settled, it should be uniform moving forward.

The changes I just made are more low-level, and should handle responsiveness better in general. Font sizes should be matched with mockups, and the title text will wrap appropriately. Also realized a few border colors were off on the form fields, so I fixed those to match the mockup.

RE mobile: it seems to be working for me, but requires a long press. This is a feature of the UI library we're using, and it looks like we can disable programmatically but it be its own small story (1-2 pts)

erikalogie commented 3 years ago

Great, thanks. One other thing: https://monosnap.com/file/SfzLXITk2m0hpeI1E75tf7iWUywUe1

I still can't get the info tooltips to come up on mobile, am I missing something?

Please add a story for upgrading the press state, thanks!

On Wed, May 12, 2021 at 4:05 PM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie I think I addressed most of what you brought up. Appreciate your eye here - sometimes modifying one value has some side effects that are hard to catch. Once we get the first few settled, it should be uniform moving forward.

The changes I just made are more low-level, and should handle responsiveness better in general. Font sizes should be matched with mockups, and the title text will wrap appropriately. Also realized a few border colors were off on the form fields, so I fixed those to match the mockup.

RE mobile: it seems to be working for me, but requires a long press. This is a feature of the UI library we're using, and it looks like we can disable programmatically but it be its own small story (1-2 pts)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/420#issuecomment-840061594, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTIW7L4ACDGMB4QKHPTTNLNRDANCNFSM42BYGLRQ .

haveanicedavid commented 3 years ago

Great, thanks. One other thing:

Done

I still can't get the info tooltips to come up on mobile, am I missing something?

Hmm, not sure. Are you on android? On iOS it seems to work, just requires a long press and hold (have to hold for a full second). I agree it should be changed though, it's annoying to use.

Please add a story for upgrading the press state, thanks!

Done!

erikalogie commented 3 years ago

Cool, yeah I think that should be fixed.

One other thing, the tooltip comes up like this for me on mobile.

El jue., 13 de may. de 2021 5:47 p. m., David Daniel < @.***> escribió:

Great, thanks. One other thing:

Done

I still can't get the info tooltips to come up on mobile, am I missing something?

Hmm, not sure. Are you on android? On iOS it seems to work, just requires a long press and hold. I agree it should be changed though, it's annoying to use.

Please add a story for upgrading the press state, thanks!

Done!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/420#issuecomment-840854109, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTIRFY2SLCGGXIV33NTTNRCHPANCNFSM42BYGLRQ .

haveanicedavid commented 3 years ago

@erikalogie did you mean to attach a picture there?

I did notice a render bug on mobile regarding the 'arrow' , if that's what you're referring to. I'll add that to the story I created to modify touch behavior

erikalogie commented 3 years ago

Yeah, sorry the image didn't attach for some reason, but that is what I am talking about.

On Fri, May 14, 2021 at 1:56 PM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie did you mean to attach a picture there?

I did notice a render bug on mobile regarding the 'arrow' , if that's what you're referring to. I'll add that to the story I created to modify touch behavior

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/420#issuecomment-841407873, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTOFPD7I6MOGAL57CNLTNVP55ANCNFSM42BYGLRQ .