search

regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Implement radio toggle field component #439

Closed blushi closed 3 years ago

blushi commented 3 years ago

https://www.figma.com/file/a1A8H2i3gBzAq915IbfDAL/Seller-Flow?node-id=5089%3A183056

All component configurations in one artboard:

https://www.figma.com/file/MuSpCtCdU2ns4cFAsPfvsx/Text-Styles-and-Components-current?node-id=4310%3A0

erikalogie commented 3 years ago

@mhagel I updated the task description with a link to an artboard with all the components. Let me know if you need anything else here!

mhagel commented 3 years ago

@erikalogie @rsteinhe Can be tested in Storybook at

https://deploy-preview-569--regen-storybook.netlify.app/?path=/story/components-inputs--toggle

erikalogie commented 3 years ago

Just a few small alignment issues: https://monosnap.com/file/2FhmKekYnbS6au0B78ns5tAn1muo7Q.

Also, the text in the tooltip is way too big, if you could reduce it to match the comps.

Great work!

On Thu, Apr 22, 2021 at 10:46 AM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie @rsteinhe https://github.com/rsteinhe Can be tested in Storybook at

https://deploy-preview-569--regen-storybook.netlify.app/?path=/story/components-inputs--toggle

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/439#issuecomment-824906381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTK47VXNWKW6GTERRPLTKAZDHANCNFSM423T4RGA .

mhagel commented 3 years ago

Just a few small alignment issues:

Good catch - fixed.

Also, the text in the tooltip is way too big, if you could reduce it to match the comps.

I should have asked you about this. I was using our existing Tooltip, which has a totally different purpose. Should be looking better now.

https://deploy-preview-569--regen-storybook.netlify.app/?path=/story/components-inputs--toggle

@erikalogie

erikalogie commented 3 years ago

It looks to me like the description text is the same size on mobile as the header text, should be slightly smaller.

The tooltips look good to me, can you just put a grey stroke around it? If this effects the global style, that is good. It just feels like it doesn't pop off the background enough.

Thanks!

On Fri, Apr 23, 2021 at 2:01 PM Mark Hagelberg @.***> wrote:

Closed #439 https://github.com/regen-network/regen-registry/issues/439 via regen-network/regen-web#569.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/439#event-4638202606, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTJDK4SYDQQ7X3DHB53TKGYWXANCNFSM423T4RGA .

blushi commented 3 years ago

@mhagel not sure why https://github.com/regen-network/regen-web/pull/569 has been closed, could you address @erikalogie's remaining comments as part of another PR?

mhagel commented 3 years ago

@mhagel not sure why https://github.com/regen-network/regen-web/pull/569 has been closed, could you address @erikalogie's remaining comments as part of another PR?

@blushi Sorry, I figured I would unblock the Eligibility PR by merging this one, since they are so closely related and I can tweak there.

Moving the responses to @erikalogie requests to https://github.com/regen-network/regen-web/pull/573