search

regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Implement registry homepage #485

Closed erikalogie closed 3 years ago

erikalogie commented 3 years ago

Desktop: https://www.figma.com/file/dSyqCESylnkyGQ2kkbFmpx/Registry-Homepage-and-Flows?node-id=1%3A687

Project dropdown: https://www.figma.com/file/dSyqCESylnkyGQ2kkbFmpx/Registry-Homepage-and-Flows?node-id=129%3A956 Credit class dropdown: https://www.figma.com/file/dSyqCESylnkyGQ2kkbFmpx/Registry-Homepage-and-Flows?node-id=219%3A0 Methodology dropdown: https://www.figma.com/file/dSyqCESylnkyGQ2kkbFmpx/Registry-Homepage-and-Flows?node-id=220%3A15127

Mobile: https://www.figma.com/file/dSyqCESylnkyGQ2kkbFmpx/Registry-Homepage-and-Flows?node-id=220%3A19564 Mobile menu: https://www.figma.com/file/dSyqCESylnkyGQ2kkbFmpx/Registry-Homepage-and-Flows?node-id=221%3A15912

Please note: we only have the grasslands credit class right now, so ignore the other credit class cards.

haveanicedavid commented 3 years ago

@erikalogie ready for review: https://deploy-preview-617--regen-registry.netlify.app

erikalogie commented 3 years ago

For the top header section, you should be able to use the already established templates for this for the Buyers, Land Steward, and many other similar pages on the website, so that the spacing and sizing is all consistent across? I realized this was my fault because I failed to do that in the comps, but I've now fixed it so assume it should look like all the other similar headers.

Can you make the underline for the rollover of "Grasslands" and "CarbonPlus Grasslands" just go under the word, not the whole section in the main navigation on desktop?

In the Credit Class section, get rid of the Forestry and CarbonPlus Lorem Ipsum Credit classes.

"Register a Project" should link to an airtable form, the same one that we have on the land steward page.

"Want to get paid..." is the wrong font weight.

I think we will need to open a separate ticket for the new Registry footer, I don't think we are ready for it since most of that content does not yet exist.

On mobile, a few small spacing issues: https://monosnap.com/file/vrD5huT91Oc4HpBwWZeImX63nMt1O0 https://monosnap.com/file/9mCzeHWaYT5qczOrKgxznqn3FFnh4O

On Tue, May 25, 2021 at 5:10 AM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie ready for review: https://deploy-preview-617--regen-registry.netlify.app

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/485#issuecomment-847696671, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTMHSCUCSX2H2YVV22DTPNSRBANCNFSM44VMZCBQ .

erikalogie commented 3 years ago

@haveanicedavid you should wait to merge this until the CarbonPlus Credit Class page that Mark is working on is finished so the main nav doesn't look weird

haveanicedavid commented 3 years ago

For the top header section, you should be able to use the already established templates for this for the Buyers, Land Steward, and many other similar pages on the website, so that the spacing and sizing is all consistent across?

@erikalogie unfortunately we can't use that section directly. The marketing site is built using a static site tool (Gatsby) but we aren't using that in the registry. I tried modifying the current component to make it work but it was causing really strange behavior and I think it's easier to just re-create.

I think I got the margins / padding closer to the background sections in the main regen site, but let me know how you'd like to adjust.

I believe I addressed the rest of your requested changes

erikalogie commented 3 years ago

It looks like the line-height is not the same for the paragraph as in the website, so that should be fixed, and the size of the paragraph on mobile is bigger here than on the website if you could reduce the size a bit.

I added another dropdown just since Thursday to the main nav and added a comment about that in Figma if you could also address that.

Ron needs to provide the paragraph of text that goes at the top too.

Can you make this line 1px wide? Fine to edit the master component, this has always bugged me: https://monosnap.com/file/DQAcjOJ7teAZ3rzKVC7GgW4Mj8qkb2

On Fri, Jun 4, 2021 at 7:10 AM David Daniel @.***> wrote:

For the top header section, you should be able to use the already established templates for this for the Buyers, Land Steward, and many other similar pages on the website, so that the spacing and sizing is all consistent across?

@erikalogie https://github.com/erikalogie unfortunately we can't use that section directly. The marketing site is built using a static site tool (Gatsby) but we aren't using that in the registry. I tried modifying the current component to make it work but it was causing really strange behavior and I think it's easier to just re-create.

I think I got the margins / padding closer to the background sections in the main regen site, but let me know how you'd like to adjust.

I believe I addressed the rest of your requested changes

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/485#issuecomment-854362692, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTPKLY6LWDIE6KBWDMDTRBN3TANCNFSM44VMZCBQ .