regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Implement Verra brokered credits Kasigau project page #526

Closed rsteinhe closed 3 years ago

rsteinhe commented 3 years ago

The project discussed is: https://www.everlandmarketing.com/projects/kasigau-corridor/ https://www.wildlifeworks.com/kenya - looks better / more relevant. https://registry.verra.org/app/projectDetail/VCS/612 - see documentation there.

We want to create a similar project page on our registry. Later on ledger-integration will be added.

Document for data gathering:

https://docs.google.com/document/d/1FQMlGruSXbl4ngIlj6xX-oVAm4qyQR80lNhptaG5RJc/edit?usp=sharing

Documents that should show on the project page:

Design comp:

https://www.figma.com/file/bY5PBiij1nAdafyshCMvXr/New-Project-Page-Design-for-Wilmot-and-Other-Impact-Ag-Projects?node-id=1546%3A1

blushi commented 3 years ago

Let's assume that we will store project data in mock.json for now but fetch documents and timeline event from the db (same as with the other projects).

rsteinhe commented 3 years ago

@erikalogie can you add the figma here?

erikalogie commented 3 years ago

@rsteinhe done

blushi commented 3 years ago

@erikalogie this is r4r on https://deploy-preview-674--regen-registry.netlify.app/projects/kasigau Please note that there seem to be some image optimization server memory issues and some images are not displaying (https://regen-network.slack.com/archives/C01LX9E8QN8/p1625648255011100 I have contacted @mhagel to look into it)

erikalogie commented 3 years ago

Ok, great. Looks good! A few small comments below, I may have more after the images are fixed.

I don't think that the location on the map is correct. If you look at the map on the Verra page, the location is further south and closer to the sea: https://registry.verra.org/app/projectDetail/VCS/612

Some small spacing issues on the project cards: https://monosnap.com/file/5d4kAVqNvPjCn3ZMdudWFgbu7ROc6N And one small spacing issue at the top of the page: https://monosnap.com/file/jMuX0fszt8WBfXNe8dsDvRpFcVMH7A

On Wed, Jul 7, 2021 at 11:30 AM Marie Gauthier @.***> wrote:

@erikalogie https://github.com/erikalogie this is r4r on https://deploy-preview-674--regen-registry.netlify.app/projects/kasigau Please note that there seems to be some image optimization server memory issues and some images are not displaying ( https://regen-network.slack.com/archives/C01LX9E8QN8/p1625648255011100 I have contacted @mhagel https://github.com/mhagel to look into it)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/526#issuecomment-875447491, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTJVBH7UCOSPVCW5FP3TWQNCDANCNFSM46H3IAIQ .

rsteinhe commented 3 years ago

@blushi looks good. a couple of comments

Aside for that looks good. There are some upgrades we'll make later on. I'm still waiting on approval so can't publish this yet.