regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Finish Methodology Review Process page & Credit class feedback #586

Closed haveanicedavid closed 3 years ago

haveanicedavid commented 3 years ago

Follow up from the following stories:

Methodology Review: https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/548

Create Credit Feedback story: https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/560

(comments in slack)

haveanicedavid commented 3 years ago

@erikalogie I still need to add links and FAQs, but the layout on methodology is ready for your eyes: https://deploy-preview-680--regen-registry.netlify.app/methodology-review-process

(I should have the credit class changes done soon, just keep getting delayed by computer issues)

erikalogie commented 3 years ago

This is looking great!

Just a few small comments:

I know you haven't added these links/FAQs yet, but just to make sure we are on the same page:

On Thu, Jul 8, 2021 at 3:17 AM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie I still need to add links and FAQs, but the layout on methodology is ready for your eyes: https://deploy-preview-680--regen-registry.netlify.app/methodology-review-process

(I should have the credit class changes done soon, just keep getting delayed by computer issues)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/586#issuecomment-876042504, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTNDXKBEAC4XYEMTDHDTWT4BVANCNFSM4744KEDQ .

haveanicedavid commented 3 years ago

@erikalogie updated methodology review process page: https://deploy-preview-682--regen-registry.netlify.app/methodology-review-process

Let me know if you want me to change the "Create a methodology" button to link to the /create-methodology page (which I adjusted the modal on and now should have the correct form): https://deploy-preview-682--regen-registry.netlify.app/create-methodology

haveanicedavid commented 3 years ago

@erikalogie I changed the way the arrow is positioned on the credit class page credit info cards here: https://deploy-preview-685--regen-registry.netlify.app/create-credit-class

erikalogie commented 3 years ago

Yes, the "create a methodology" button should link to /create-methodology

The arrow still looks messed up to me, as well as the gaps on the side on mobile: https://monosnap.com/file/p2T71U1axPeWBTwoNYjrjSnA6l9aG0

I see another issue on the credit class page that I missed before: https://monosnap.com/file/3Rh4Waqt8CXHaPP86Kz7t3ypXDLX1U

Thanks!

On Wed, Jul 14, 2021 at 10:45 PM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie I changed the way the arrow is positioned on the credit class page credit info cards here: https://deploy-preview-685--regen-registry.netlify.app/create-credit-class

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/586#issuecomment-880196594, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTLMPKWXG6WTJVPZVVTTXXZOVANCNFSM4744KEDQ .

haveanicedavid commented 3 years ago

@erikalogie are you sure you're looking at the right deploy preview? On mine this is how the arrows look: Screen Shot 2021-07-15 at 7.16.32 PM.png

I shared two separate deploy previews in this thread, and the credit class tweaks will only show on this one: https://deploy-preview-685--regen-registry.netlify.app/create-credit-class

Just pushed a commit to fix that padding under the title section as well as the gap on the sides while scrolling through cards

haveanicedavid commented 3 years ago

@erikalogie /methodology-review-process page with updated button (links to /create-methodology): https://deploy-preview-682--regen-registry.netlify.app/methodology-review-process

The changes to the slider (from the discussion in this thread are also on this deploy preview (different than the one above) - you can see them on tablet resolution at: https://deploy-preview-682--regen-registry.netlify.app/create-methodology

erikalogie commented 3 years ago

Slider changes look good to me.

On the "create methodology" page, the "see the review process" button under the "Participate in Methodology Review" headline should now link to the methodology review process page.

Sorry to be harping on and on about the "evaluate new approaches" cards but I think what would make most sense is to use a check icon in the header text (like from font awesome or equivalent), so then you can treat it like normal header text and not have to do all this weird div stuff that breaks the lines of text and looks awkward on mobile: https://monosnap.com/file/HdE7Ofc6wa2yEQ9Pa8l2SE2U9FFpCa

On Fri, Jul 16, 2021 at 5:25 AM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie /methodology-review-process page with updated button (links to /create-methodology): https://deploy-preview-682--regen-registry.netlify.app/methodology-review-process

The changes to the slider are also on this deploy preview (different than the one above) - you can see them on tablet resolution at: https://deploy-preview-682--regen-registry.netlify.app/create-methodology

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/586#issuecomment-881148577, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTOY43BAFNQUTCUXBJDTX6RCTANCNFSM4744KEDQ .

haveanicedavid commented 3 years ago

@erikalogie I tried using font awesome icons but ran into the same issue... I tried another approach with styles which should render closer to normal inline text... take a look and let me know what you think: https://deploy-preview-685--regen-registry.netlify.app/create-credit-class

(also the link on /create-methodology should be fixed)

erikalogie commented 3 years ago

Looks great!

On Tue, Jul 20, 2021 at 1:17 AM David Daniel @.***> wrote:

@erikalogie https://github.com/erikalogie I tried using font awesome icons but ran into the same issue... I tried another approach with styles which should render closer to normal inline text... take a look and let me know what you think: https://deploy-preview-685--regen-registry.netlify.app/create-credit-class

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/586#issuecomment-882923435, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTMTQFGOGW7OQQ5OGKLTYSXADANCNFSM4744KEDQ .