Continue: Edit Project Page

[mhagel]

Continuation of regen-network/regen-registry#361

[mhagel]

@erikalogie You may review at https://deploy-preview-809--regen-registry.netlify.app/project-pages

Click "edit" to edit a project page. Updates should save (staging DB), but I think the Roles form is messed up.

[erikalogie]

Yes, the roles form seems to be messed up. I can't add a new organization at all.

I'm noticing that the search icon is missing from all the location input boxes (refer to designs).

It would be ideal if the left bar was centered in the middle section with the main content. I know it wasn't like this in the designs because there was a different navigation and such, but I think it would look better, something like this: https://monosnap.com/file/mzzPxPFpLkjAJM4SoBo39rG9kKPIXG

The background of the left-hand nav box should be white. Ideally the selected arrow would be grey as in the comps but if this is more than a very quick fix, don't worry about it.

The save button seems to be missing from the mobile view.

I can't actually get most things to save. I also can't delete the photos to add new ones. Is that part of a different task?

Is the settings section also part of a different task?

I should be able to edit the organization info and I don't see the edit button.

Small spacing thing: https://monosnap.com/file/iBfs7AEvgXV5uv44VBQHAIbT8tSy8C

On Thu, Dec 2, 2021 at 4:44 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie You may review at https://deploy-preview-809--regen-registry.netlify.app/project-pages

Click "edit" to edit a project page. Updates should save (staging DB), but I think the Roles form is messed up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/754#issuecomment-984986611, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTKNAF2HGXS3MMCLSYLUO7LBZANCNFSM5IT5724Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[mhagel]

@erikalogie

Yes, the roles form seems to be messed up. I can't add a new organization at all.

I will create a bug.

I'm noticing that the search icon is missing from all the location input boxes (refer to designs).

I didn't change this component. Maybe this was overlooked before. I would also suggest it needs an "X" icon for clearing the field too. Please create a new issue if you would like these addressed.

It would be ideal if the left bar was centered in the middle section with the main content. I know it wasn't like this in the designs because there was a different navigation and such, but I think it would look better, something like this: https://monosnap.com/file/mzzPxPFpLkjAJM4SoBo39rG9kKPIXG

Done.

The background of the left-hand nav box should be white. Ideally the selected arrow would be grey as in the comps but if this is more than a very quick fix, don't worry about it.

FIxed.

The save button seems to be missing from the mobile view.

LMK is you are still seeing this.

I can't actually get most things to save. I also can't delete the photos to add new ones. Is that part of a different task?

Delete should work now. But we will fine tune it with another task (created already(

Is the settings section also part of a different task?

Yes

I should be able to edit the organization info and I don't see the edit button.

Should be fixed with Roles form.

Small spacing thing: https://monosnap.com/file/iBfs7AEvgXV5uv44VBQHAIbT8tSy8C

fixed

https://deploy-preview-809--regen-registry.netlify.app/project-pages

[erikalogie]

On Mon, Dec 6, 2021 at 6:36 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie

Yes, the roles form seems to be messed up. I can't add a new organization at all.

I will create a bug.

I'm noticing that the search icon is missing from all the location input boxes (refer to designs).

I didn't change this component. Maybe this was overlooked before. I would also suggest it needs an "X" icon for clearing the field too. Please create a new issue if you would like these addressed.

Ok, I added this bug: https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/770 https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/770

It would be ideal if the left bar was centered in the middle section with the main content. I know it wasn't like this in the designs because there was a different navigation and such, but I think it would look better, something like this: https://monosnap.com/file/mzzPxPFpLkjAJM4SoBo39rG9kKPIXG

Done.

The background of the left-hand nav box should be white. Ideally the selected arrow would be grey as in the comps but if this is more than a very quick fix, don't worry about it.

FIxed.

It still isn't white: https://monosnap.com/file/SfKSaCjTbBglaHTKALmrF2YWZUgB4a https://monosnap.com/file/SfKSaCjTbBglaHTKALmrF2YWZUgB4a Also, can you fix the margins on the sides on mobile? Should be the same as after you click on one of the sections. https://monosnap.com/file/b6qsCsrBpjndZYkadvhIqnqfGKYwa7 https://monosnap.com/file/b6qsCsrBpjndZYkadvhIqnqfGKYwa7

The save button seems to be missing from the mobile view.

LMK is you are still seeing this.

Great, I see it now. Can you make it a bit bigger, like in the comps? And also remove the footer?

I can't actually get most things to save. I also can't delete the photos to add new ones. Is that part of a different task?

I think the issue here is that I don't have the feedback when something has saved, so I'm navigating away from the page prior. I think in addition to a "changed have been saved" notification message at the top, there should be a warning when you leave the page that warns you you are about to lose your changes. I can make a design for such a simple dialog box for you, and we could add another task for that to be tackled separately. But the notification should be easy to implement so maybe you could do that now?

Delete should work now. But we will fine tune it with another task (created already(

Is the settings section also part of a different task?

Yes

I should be able to edit the organization info and I don't see the edit button.

Should be fixed with Roles form.

Ok, where is that captured?

Small spacing thing: https://monosnap.com/file/iBfs7AEvgXV5uv44VBQHAIbT8tSy8C

fixed

https://deploy-preview-809--regen-registry.netlify.app/project-pages

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/754#issuecomment-987310961, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTIHFFKCBURY342Q57TUPU3GLANCNFSM5IT5724Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[mhagel]

@erikalogie https://deploy-preview-809--regen-registry.netlify.app/project-pages

Ok, fixed the white (my bad), fixed the mobile nav spacing, cleaned up some other CSS, added confirm save banner, hid the footer, tweaked the button.

Roles form bug

Settings issue

[erikalogie]

If I replace an image I can't save the form afterwards. I also can't change the location and save it afterwards, will send you a video on slack.

Small spacing issues I just noticed: https://monosnap.com/file/Qu9BmEsQpQAPhcZ0D9RM6b691C2C4o https://monosnap.com/file/1Nk3ORoBaWJtvhd1OIuWMFhR434Wqu

On Tue, Dec 7, 2021 at 7:12 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie https://deploy-preview-809--regen-registry.netlify.app/project-pages

Ok, fixed the white (my bad), fixed the mobile nav spacing, cleaned up some other CSS, added confirm save banner, hid the footer, tweaked the button.

Roles form bug https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-web/811

Settings issue https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-web/812

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/754#issuecomment-988330158, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTKNLOT44H4ERXEBEF3UP2IHJANCNFSM5IT5724Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[mhagel]

@erikalogie Ok, it took some experimenting, but I think Location is good now. For Media, you may want to try with a fresh project. LMK if still trouble. thanks.

[erikalogie]

Now it is prompting me to save the location when all I've done is put the cursor in the field.

Also, I'm trying to make a new project and now I can't save the media page. I've uploaded 4 photos but it still says "you must add 4 photos": https://monosnap.com/file/5Y9nf1HbhHRQHCrQjLAWSWhrM5RhDx

On Wed, Dec 8, 2021 at 8:06 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie Ok, it took some experimenting, but I think Location is good now. For Media, you may want to try with a fresh project. LMK if still trouble. thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/754#issuecomment-989327923, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTKR45FBVH6KGOVDWBTUP7XJ5ANCNFSM5IT5724Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[mhagel]

@erikalogie Nice catches! Thanks for the great QA- we had some bugs in there. I think they should be good now.

[erikalogie]

I'm still not able to save the photos on the media page: https://monosnap.com/file/ebikOumbwedhUuORwIcqfwPPmuvJI0 and also on the media form, will send you a video of that.

Also, on the edit form, there needs to be more space at the bottom: https://monosnap.com/file/UENMzD25yWDAShVljPGlyGKRjnR97N

On Thu, Dec 9, 2021 at 5:00 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie Nice catches! Thanks for the great QA- we had some bugs in there. I think they should be good now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/754#issuecomment-990248246, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTJBSZNUZNQPO7PBQ33UQEKGPANCNFSM5IT5724Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.