regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Implement support for login with Keplr Wallet #757

Closed frumioj closed 1 year ago

frumioj commented 2 years ago

Using Keplr JS APIs documented in XXX and available in the Commonwealth repo: https://github.com/hicommonwealth/commonwealth, specifically https://github.com/hicommonwealth/commonwealth/blob/master/client/scripts/controllers/app/webWallets/keplr_web_wallet.ts allow a user to login via Keplr in addition to the existing auth0 mechanisms.

This requires some changes on the front end (allow the user to choose login with Keplr along with the existing auth0 social logins) and changes on the backend (authenticate with Keplr transaction signing as shown in JS links, and create a linked user profile that is linked either to a Keplr wallet or a social login).

clevinson commented 2 years ago

So i think the use case we should be holding when thinkng abt authx prioritization of these tickets is one where an issuer of a credit wants to add some fully offchain metadata to a credit batch (like profile pictures to a project page).

The use case IMO would look something like: User goes to registry page (let’s say project page, assuming projects are live on regen ledger by now) and connects with Keplr The app detects that a user’s regen account is issuer who created this on-chain project, and therefore exposes an exposes an “edit” button on the project page so the user can add profile pictures and other fully-offchain/centralized metadata The user can edit & save metadata, as well as add other regen user account names as “collaborators” so they can directly edit project page website as well

I think that given where we’re at with current priorities, this flow described above is likely higher priority than any other logged in user interactions that we previously were discussing. And if we want to support a “create an account” flow for folks who don’t have a regen account, it will probably be true that those users only have anything to do (in terms of editing content on project pages) once the on-chain project creator (a regen address) explicitly adds them as a collaborator to that project page via the flow i described above.

frumioj commented 2 years ago

Has @erikalogie looked at or prototyped the UI flow for this already? How close are we to having the ability for a developer to start working o it?

erikalogie commented 2 years ago

I haven't prototyped a different flow than what is used on desktop, but I thought that it would essentially work the same and would just open the keplr mobile app instead of the kepler wallet extension in the browser.

On Tue, Mar 8, 2022 at 5:13 PM John Kemp @.***> wrote:

Has @erikalogie https://github.com/erikalogie looked at or prototyped the UI flow for this already? How close are we to having the ability for a developer to start working o it?

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/757#issuecomment-1062217086, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTKMDWILGBDFDUWYAVTU667HJANCNFSM5JG7QIGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

frumioj commented 2 years ago

cc @wgwz @mhagel for awareness.

ryanchristo commented 1 year ago

After switching #1691 and #1700 to the web2 login/profile epic, I'm going to close this epic out as complete. Any new changes we want to make to the integration with keplr should be taken into account alongside our current work.