Upgrade Regen JS to latest version in web-registry

regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)

0 stars 0 forks source link

Upgrade Regen JS to latest version in web-registry #850

Closed S4mmyb closed 2 years ago

S4mmyb commented 2 years ago

Upgrade Regen JS to latest version (v0.2.2) in web-registry

The API has been changed:

api.connection.queryConnection -> api.queryClient
https://github.com/regen-network/regen-web/blob/d430855fe0049316d79cd61bd3af56165687a1d0/web-registry/src/types/ledger/ecocredit.ts#L2, this interface now has a $type field so we might just need to create a custom type instead for representing the REST query response

blushi commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @haveanicedavid @mhagel @victordelval

victordelval commented 2 years ago

When updating the regen-js api package (0.2.1), I get the following error when updating the tests in the web-registry subdirectory (...regen-web/web-registry$ yarn test- update-snapshot)

more details, importing RegenApi in ledger.tsx https://github.com/regen-network/regen-web/runs/5489407065?check_suite_focus=true

victordelval commented 2 years ago

Marie response

the @regen-network/api package is now built as an ecmascript module because of some changes in the typescript config in regen-js, which Jest only has experimental support for.

I’ll need to revert this back but this might deserve its own issue