regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Add test runner to CI in registry-server #862

Closed wgwz closed 2 years ago

wgwz commented 2 years ago

This is an issue we created because I started work for this in https://github.com/regen-network/regen-registry/issues/756 via this PR https://github.com/regen-network/registry-server/pull/128. We wanted to create a separate task for this as it should have been treated as a separate task. And it also helps to keep track of the work we've done in this sprint.

The goal of this task would be to get the tests running as a part of the CI github action. This is completed now, and it's been done by using the "Services" feature of Github actions. This allowed us to run a postgis database in a container, such that the tests could be run. This is effectively a dummy database in that there is no real data. However it will apply all migrations.

This means that each time a new push is made for any non-master branch, both the lint/format check and the tests will be run.

c.c. @blushi (Marie - My estimate for this would be a two but this is a little bit of a bias because the work is already done.)

wgwz commented 2 years ago

@blushi btw if you think there is more that needs to be accomplished here, glad to have that discussion. i aimed for the minimum viable setup to enable running the tests as if you were doing local development (without any real data present)