search

regen-network / rnd-dev-team

RND Dev Team issue management (DEPRECATED)
0 stars 0 forks source link

Update batch detail page with new metadata fields #870

Closed erikalogie closed 2 years ago

erikalogie commented 2 years ago

https://www.figma.com/file/seUiQM2SPt78KJiDL0Ea8m/Basic-Ecocredits-Ledger-View?node-id=1448%3A95862

Get rid of the verification and monitoring docs and add the additional certifications here rather than on the project page.

blushi commented 2 years ago

@erikalogie why is this blocked on https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/868?

blushi commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @haveanicedavid @mhagel @victordelval

erikalogie commented 2 years ago

@blushi because I assumed that dev needs the design of where to put the new fields on the page first

On Tue, Mar 29, 2022 at 3:31 AM Marie Gauthier @.***> wrote:

Hey team! Please add your planning poker estimate https://app.zenhub.com/workspaces/Regen-Registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/870?planning-poker with ZenHub @haveanicedavid https://github.com/haveanicedavid @mhagel https://github.com/mhagel @victordelval https://github.com/victordelval

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/870#issuecomment-1081515597, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTOU3MHQCUUX4YNP5RTVCKWULANCNFSM5R3VY2RQ . You are receiving this because you were mentioned.Message ID: @.***>

erikalogie commented 2 years ago

@mhagel this is ready to work on

S4mmyb commented 2 years ago

@mhagel Put in a PR here with some batch data if you're ready to toy around with it: https://github.com/regen-network/regen-registry-ops/blob/sam/C01-pilot-batches/C01/credit-batch-metadata/C01-20150101-20151231-002.json

mhagel commented 2 years ago

@S4mmyb should we also remove regen:vintageYear? It wasn't mentioned in this issue, but it is in a previous metadata interface in the front end.

Also, I think we need add a '@list' identifier to the additionalCerts array, as such:

nevermind - I understand that the @list is explained in the context now.

mhagel commented 2 years ago

@erikalogie Ready for feedback: https://deploy-preview-910--regen-registry.netlify.app/credit-batches/C01-20190101-20210101-008

erikalogie commented 2 years ago

Looks good to me!

On Fri, Apr 22, 2022 at 1:12 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie Ready for feedback:

https://deploy-preview-910--regen-registry.netlify.app/credit-batches/C01-20190101-20210101-008

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/870#issuecomment-1106706348, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTM26OCLBXJJCMHSZHDVGLMWPANCNFSM5R3VY2RQ . You are receiving this because you were mentioned.Message ID: @.***>

S4mmyb commented 2 years ago

@S4mmyb should we also remove regen:vintageYear? It wasn't mentioned in this issue, but it is in a previous metadata interface in the front end.

Hey @mhagel, the vintage year should also be removed, yes. The vintage year should be calculated based on the start and end date parameters in the batch issuance ecocredit spec: https://github.com/regen-network/regen-ledger/blob/e4e9a152c2cc28494946b33280a04538cdded0e7/proto/regen/ecocredit/v1/state.proto#L143