Issuing Credits on Chain - Credit basics

S4mmyb commented 2 years ago

This is about implementing the first step of the process for issuing credits on chain (Credit basics) https://www.figma.com/file/TyhFaXqko9F8OvLEE4Zomg/Issuer-Create%2FEdit-Projects%2C-Credit-Class%2C-Batches?node-id=74%3A24621

Prototype view of the full flow: https://www.figma.com/proto/TyhFaXqko9F8OvLEE4Zomg/Issuer-Create%2FEdit-Projects%2C-Credit-Class%2C-Batches?page-id=69%3A22030&node-id=74%3A24621&viewport=241%2C48%2C0.15&scaling=scale-down&starting-point-node-id=74%3A24621

Do not add the project select field as part of this issue: https://www.figma.com/file/TyhFaXqko9F8OvLEE4Zomg?node-id=74:24621#172601988

blushi commented 2 years ago

@erikalogie should that include all the steps from https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/854? I guess we should rather split them up into multiple issues... cc/ @S4mmyb

erikalogie commented 2 years ago

I believe this task is just about developing the "create credit batch" flow. I'll add the Figma comps to this task.

On Tue, Apr 12, 2022 at 5:43 AM Marie Gauthier @.***> wrote:

@erikalogie https://github.com/erikalogie should that include all the steps from https://app.zenhub.com/workspaces/regen-registry-5f8998bec8958d000f4609e2/issues/regen-network/regen-registry/854 ? I guess we should rather split them up into multiple issues... cc/ @S4mmyb https://github.com/S4mmyb

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/892#issuecomment-1096456108, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTLEH4Z6XXE2K67FSSTVEVAVFANCNFSM5S4ZQYBA . You are receiving this because you were mentioned.Message ID: @.***>

erikalogie commented 2 years ago

I can add mobile comps for this later this week

blushi commented 2 years ago

@blushi TODO split it up into 3 subtasks:

Credit basics form
Recipients form
Review/submission/success screens

blushi commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @haveanicedavid @mhagel @wgwz

blushi commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @haveanicedavid @victordelval

mhagel commented 2 years ago

@erikalogie Before I get too deep into Date Picker land... Here are some options:

Easiest: Have separate fields for Start Date and End Date (differs from mocks)
Mid: Pay for MUI Pro Licenses so we can use their DateRangePicker component (still not sure if it can easily match the look in the mockups)
Hard: Use a free DatePicker library and restyle it.

These date components can be a real time black hole, so I just wanted to get your thoughts.

erikalogie commented 2 years ago

The first option is totally fine, I can rework the mocks

El jue., 28 de abr. de 2022 19:17, Mark Hagelberg @.***> escribió:

@erikalogie https://github.com/erikalogie Before I get too deep into Date Picker land... Here are some options:

Easiest: Have separate fields for Start Date and End Date (differs from mocks)

Mid: Pay for MUI Pro Licenses so we can use their DateRangePicker https://mui.com/x/react-date-pickers/date-range-picker/ component (still not sure if it can easily match the look in the mockups)

Hard: Use a free https://reactdatepicker.com/#example-date-range DatePicker library and restyle it.

These date components can be a real time black hole, so I just wanted to get your thoughts.

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/892#issuecomment-1112738574, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTOZRSS4EOXX42XHS23VHML7RANCNFSM5S4ZQYBA . You are receiving this because you were mentioned.Message ID: @.***>

mhagel commented 2 years ago

@erikalogie Ok. Not finished, but looking like this so far:

Screen Shot 2022-04-29 at 4.01.19 PM.png

Screen Shot 2022-04-29 at 4.05.31 PM.png

erikalogie commented 2 years ago

This looks good to me!

El vie., 29 de abr. de 2022 18:06, Mark Hagelberg @.***> escribió:

@erikalogie https://github.com/erikalogie Ok. Not finished, but looking like this so far:

[image: Screen Shot 2022-04-29 at 4.01.19 PM.png] https://camo.githubusercontent.com/ad70e310f760a6b2802553492dc534a709ff3a50ab2de828c233b824a06a810c/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630313462656339613265623039613834346666623239352f35383937343236342d393166632d346635392d393833302d356663646338336236643963

[image: Screen Shot 2022-04-29 at 4.05.31 PM.png] https://camo.githubusercontent.com/87e13d6c698fe2eb50ac832649f8eceaa982246771fd1ec4d060f4d403e9c967/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630313462656339613265623039613834346666623239352f31306635643064372d303464342d343637322d383265342d643532613733663939373066

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/892#issuecomment-1113794394, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTJZNTXJELGW3UPMJ7TVHRMPXANCNFSM5S4ZQYBA . You are receiving this because you were mentioned.Message ID: @.***>

mhagel commented 2 years ago

@erikalogie Ready for feedback: https://deploy-preview-940--regen-registry.netlify.app/credit-batch/basics

erikalogie commented 2 years ago

This looks great! Let's make the "additional certificate name" not optional. As mentioned in the call, I think we should add some validation for the VCS retirement serial number.

On Wed, May 11, 2022 at 1:30 AM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie Ready for feedback: https://deploy-preview-940--regen-registry.netlify.app/credit-batch/basics

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/892#issuecomment-1123287208, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTIRUPUQM3GBHH5B7CLVJNOXTANCNFSM5S4ZQYBA . You are receiving this because you were mentioned.Message ID: @.***>

mhagel commented 2 years ago

@erikalogie Some updates - can you take a look please? https://deploy-preview-940--regen-registry.netlify.app/ecocredits/create-batch

Notes:

I know i need to fix the metadata spacing.
Only C01 would be visible in Prod. Redwood has more credit classes.

erikalogie commented 2 years ago

Looks good.

I think that the project field should be persistent for all credit classes.

See the updates and comments here on the project field: https://www.figma.com/file/TyhFaXqko9F8OvLEE4Zomg?node-id=74:24702#195583915

On Wed, May 18, 2022 at 4:45 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie Some updates - can you take a look please?

https://deploy-preview-940--regen-registry.netlify.app/ecocredits/create-batch

Notes:

I know i need to fix the metadata spacing.

Only C01 would be visible in Prod. Redwood has more credit classes.

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/892#issuecomment-1130109909, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTORLQNVQEZOGIJX57TVKT67PANCNFSM5S4ZQYBA . You are receiving this because you were mentioned.Message ID: @.***>

mhagel commented 2 years ago

@erikalogie Cool. Ready for another look: https://deploy-preview-940--regen-registry.netlify.app/ecocredits/create-batch

erikalogie commented 2 years ago

Looks great!

On Thu, May 19, 2022 at 2:41 AM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie Cool. Ready for another look: https://deploy-preview-940--regen-registry.netlify.app/ecocredits/create-batch

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/892#issuecomment-1130857240, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTMKLGH6WI2H64LCYIDVKWE2HANCNFSM5S4ZQYBA . You are receiving this because you were mentioned.Message ID: @.***>

mhagel commented 2 years ago

@erikalogie A few more updates if you want to test one more time: https://deploy-preview-940--regen-registry.netlify.app/ecocredits/create-batch

Here is a sample VSC retirement serial number you can use: 10695-239407151-239407157-VCS-VCU-466-VER-PG-14-2293-01062017-31122019-0

erikalogie commented 2 years ago

This looks great.

I just realized that it would be nice to add a little paragraph with a hint about what the VCS serial number should look like. I added it to these comps: https://www.figma.com/file/TyhFaXqko9F8OvLEE4Zomg/Issuer-Create%2FEdit-Projects%2C-Credit-Class%2C-Batches?node-id=74%3A24702

On Tue, May 31, 2022 at 9:27 PM Mark Hagelberg @.***> wrote:

@erikalogie https://github.com/erikalogie A few more updates if you want to test one more time:

https://deploy-preview-940--regen-registry.netlify.app/ecocredits/create-batch

Here is a sample VSC retirement serial number you can use: 10695-239407151-239407157-VCS-VCU-466-VER-PG-14-2293-01062017-31122019-0

— Reply to this email directly, view it on GitHub https://github.com/regen-network/regen-registry/issues/892#issuecomment-1142559030, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARPTIUKA5JUWX3PTWZ653VMZR3NANCNFSM5S4ZQYBA . You are receiving this because you were mentioned.Message ID: @.***>

regen-network / rnd-dev-team

Issuing Credits on Chain - Credit basics #892