search

regilero / check_phpfpm_status

Nagios check for php-fpm status report
GNU General Public License v3.0
39 stars 19 forks source link

changed tempfile naming, added some debugging and fixed a typo #23

Open magenbrot opened 5 years ago

magenbrot commented 5 years ago

Hi @regilero,

I've had a problem while using your check. The temporary file was created with the hostname given as argument. This leads to problems when you have more than one PHP-FPM pool, since all data was written to the same file when using multiple checks.

I've changed the $TempFile variable to use the $Pool from the status page result.

Additionally I added some more debugging and fixed a typo.

regilero commented 5 years ago

Hello, that's effectively a problem. Thanks for writing a fix. But from what I can read on your patch you replace this problem by another one, what about multiple servers having the same pool name? Could you rewrite your fix and alter the temporary filename by adding both the pool name and the host name? Then you could also add a a line with your name in the CHANGELOG, and a quick issue description.

magenbrot commented 5 years ago

you're right. I'll change that