search

registerguard / benjamins

Responsive ad delivery script in conjunction with ad_manager app. Helps make lots of benjamins!
Apache License 2.0
1 stars 0 forks source link

Change "section" to "target"... #2

Open mhulse opened 11 years ago

mhulse commented 11 years ago

This can be done at any time. Just need to update all the bulldog templates calling the the aq_manager JS.

psullivan6 commented 11 years ago

Should we rename all the parameters?

Currently, they are: parent, section, and page.

Also, should page change to the story ID just because we can get it for free? We can get story specific ads on the blogs with a custom field, so that negates the ID being needed, but might be helpful in the future. Also does an ID show on blog section fronts? If not, we're golden: we can use a Boolean check on story ID to determine if it's a story page or not.

mhulse commented 11 years ago

Should we rename all the parameters? Currently, they are: parent, section, and page.

I think section is the only one that's needing change. It's the only one that does not match our models:

screen shot 2013-07-01 at 4 00 23 pm

Also, target is nice and generic, whereas the other are already semi-generic or generic enough.

The motivation to change section is because we might not always be passing an actual "section" to the code.

On the other hand, I'm open to name changing ideas, though, I think they should try to match the back end model names (or not?). I'm open to discussion.

Also, should page change to the story ID just because we can get it for free? We can get story specific ads on the blogs with a custom field, so that negates the ID being needed, but might be helpful in the future. Also does an ID show on blog section fronts? If not, we're golden: we can use a Boolean check on story ID to determine if it's a story page or not.

Not sure if I completely follow here. Sorry. :frowning:

Are you asking if page label should get changed to something like story_id?

My gut is telling me that we should not focus on how we get the code to the JS/Django app, as the possibilities are endless in terms of how to handle that. I think we can't go wrong if we keep name generic and allow for flexibility in terms of data that gets passed around.

Sorry if I'm not understanding your question.

mhulse commented 11 years ago

Related: New blog: Storytellers

As noted in that issue, we had talked about a custom field on stories where we assign the "target" value.

For other systems, like DTI/Lighting, we could create a custom InCopy field to do the same (name it something like WebAdTarget), or we could just pass the story ID (or even the story slug, example: web.firefighters-2.0701).

I can even concat values to make up things.

Going back to the target, if it's renamed then I think it makes more logical sense when passing in story IDs, slugs or custom field values.

psullivan6 commented 11 years ago

Ditto :+1: