search

registerguard / bulldog

The official 2013 registerguard.com theme.
http://registerguard.com
1 stars 1 forks source link

Footer navigation spacing (remove .bd_box from PDF parent in footer) #151

Open psullivan6 opened 11 years ago

psullivan6 commented 11 years ago

I noticed that the spacing on the Subscriber Services <select> is a bit off on the Alpha breakpoint (too much between header and select box). If I'm not mistaken, is it from .bd_box having a table display here: https://github.com/registerguard/bulldog/blob/master/build/files/css/less/base.less#L276 ... perhaps make it display: block on alpha?

krill-spacing

mhulse commented 11 years ago

.bd_box is just the micro clearfix:

http://nicolasgallagher.com/micro-clearfix-hack/

Looks like it's because the clearfix contains margins instead of let them collapse.

The clearfix is there for the PDF at larger breakpoints. IIRC, at one point I added clearfix because I wanted to make sure the PDF never escaped its parent container. I can remove it though, as the PDF is never taller than the unordered list sibling.

Good catch!