search

registerguard / bulldog

The official 2013 registerguard.com theme.
http://registerguard.com
1 stars 1 forks source link

Logic bug: MOVE AD MANAGER BELOW BULLDOG CSS!!!!! #170

Closed mhulse closed 10 years ago

mhulse commented 10 years ago

Ran into a bug today, pointed out by Melissa, that ad weren't loading in Chrome.

After most of a day of debugging, I narrowed down the problem to this one line:

html,button,input,select,textarea{font-family:sans-serif;}

When I removed html,, the ads loaded!

Turns out I was loading Bulldog's CSS AFTER Ad Manager's CSS, causing Bulldog's CSS to trump Ad Manager's CSS.

Ad Manager uses the html element to set custom/invalid font family names so that it can communicate with JS and we can have responsive ads. Because I had Bulldog's CSS come second, it overrode Ad Manager.

Took most of my day to find a five character bug.

Fixing now.

mhulse commented 10 years ago

Blogs and Dox both updated with rearranged HTML.