search

registreerocks / registree-core

0 stars 0 forks source link

Added a service for faculties and in the faculties resolver I added a query to get a single faculty by Id #380

Closed Nghondzweni closed 3 years ago

longtomjr commented 3 years ago

Just another comment. It looks like the precommit hooks are not running on your side properly. We have hooks that check the format of the commit message using commit-lint, and make sure that committed code passed the linting and prettier constraints.

I am not sure what the issue could be, we can have a look at debugging and getting it set up.

codecov[bot] commented 3 years ago

Codecov Report

Merging #380 (eec8dcf) into staging (de4b9b1) will decrease coverage by 0.14%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging     #380      +/-   ##
===========================================
- Coverage    74.49%   74.35%   -0.15%     
===========================================
  Files          141      141              
  Lines         2270     2281      +11     
  Branches       177      178       +1     
===========================================
+ Hits          1691     1696       +5     
- Misses         578      584       +6     
  Partials         1        1
Impacted Files Coverage Δ
src/universities/universities.service.ts 65.78% <0.00%> (-3.66%) :arrow_down:
src/universities/resolvers/faculties.resolver.ts 75.00% <60.00%> (-5.65%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de4b9b1...eec8dcf. Read the comment docs.

PiDelport commented 3 years ago

(@Nghondzweni: Note that you don't have to create a new PR when updating a branch: continuing on this PR would have been fine. 🙂️)