search

registreerocks / registree-core

0 stars 0 forks source link

ci: improve Docker build #400

Closed PiDelport closed 2 years ago

PiDelport commented 2 years ago

This adds a goss test for the Docker image, which validates that the process starts and listens correctly. πŸŽ‰

This should catch any future regressions like the recent one with Yarn 3 requiring additional files in the image to run correctly, but this also updates the Docker image to run just Node + PnP, without needing Yarn.

codecov[bot] commented 2 years ago

Codecov Report

Merging #400 (4f78d6e) into staging (a573fb5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           staging     #400   +/-   ##
========================================
  Coverage    77.49%   77.49%           
========================================
  Files          144      144           
  Lines         2128     2128           
  Branches       134      134           
========================================
  Hits          1649     1649           
  Misses         448      448           
  Partials        31       31

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update a573fb5...4f78d6e. Read the comment docs.

PiDelport commented 2 years ago

Successful dgoss output:

PiDelport commented 2 years ago

Do we still need the non-docker build job?

No, but I reckon it's not terrible to keep it around, for now: the Docker build isn't as well-cached, yet, so the non-Docker build will give earlier feedback. (Currently, ~1 minute versus ~3 minutes.)