search

registreerocks / registree-core

0 stars 0 forks source link

feat(queries): add support for filtering based on average #413

Closed longtomjr closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #413 (c2252e2) into staging (65950bb) will decrease coverage by 0.12%. The diff coverage is 72.97%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging     #413      +/-   ##
===========================================
- Coverage    77.47%   77.35%   -0.13%     
===========================================
  Files          144      145       +1     
  Lines         2131     2155      +24     
  Branches       135      138       +3     
===========================================
+ Hits          1651     1667      +16     
- Misses         449      454       +5     
- Partials        31       34       +3
Impacted Files Coverage Δ
src/common/amount.union.ts 66.66% <57.14%> (-6.67%) :arrow_down:
src/queries/queries.service.ts 51.85% <72.72%> (-0.06%) :arrow_down:
src/common/average.model.ts 80.00% <80.00%> (ø)
src/queries/dto/degree.input.ts 100.00% <100.00%> (ø)
src/queries/mappers/map-query-details.ts 100.00% <100.00%> (ø)
src/queries/models/degree-selection.model.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65950bb...c2252e2. Read the comment docs.

longtomjr commented 2 years ago

Do we need to add average field to the tests in amount.union.regression.spec.ts?

Otherwise the rest of the PR LGTM.

Good catch. Added it to that test.