search

registrobr / whmcs-registrobr-epp

WHMCS Registrar Module for interfacing to Registro.br EPP
GNU General Public License v3.0
41 stars 21 forks source link

PHP 5.5 will deprecate MySQL functions currently in use; Pear_Error also to be deprecated #26

Closed registrobr closed 1 year ago

registrobr commented 11 years ago

http://php.net/manual/en/migration55.deprecated.php

registrobr commented 11 years ago

Pear: Error also seems to be deprecated or about to. From whmcs-coza-epp mailing list:

"110%, thanks Michael.

If we can track it down to that single PEAR_Error() I think that warrants me rewriting the module to use exceptions instead, seems that the PEAR Error() handling is marked as deprecated in alot of places v0v"

registrobr commented 10 years ago

Currently not a problem since WHMCS doesn't support PHP 5.5 due to Ioncube restrictions. The new Ioncube loader supports PHP 5.5 but WHMCS, including up to 5.3.8, is encoded using previous Ioncube version that do not support the new loader. It is also said that WHMCS itself uses the same 5.5 deprecated versions, so it might be long before this issue becomes a problem.

Status might be changed from wontfix in the future; issue will remain open with no milestone.

registrobr commented 9 years ago

PHP 5.4 already complains about some of the issues: Strict Standards: Non-static method PEAR::isError() should not be called statically in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Protocol.php on line 73

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in/home/super/public_html/home/modules/registrars/registrobr/RegistroEPP/RegistroEPP.class.php on line 172

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Client.php on line 112

Strict Standards: Non-static method PEAR::isError() should not be called statically in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Protocol.php on line 73

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Client.php on line 112

Strict Standards: Non-static method PEAR::isError() should not be called statically in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Protocol.php on line 73

registrobr commented 9 years ago

Perhaps the changes already made at https://gitlab.centralnic.com/centralnic/php-epp/tree/master/Net/EPP solve the mentioned issues

registrobr commented 9 years ago

WHMCS v6 will support PHP 5.5+, so WHMCS v6 interoperability (besides possible registrar module issues yet to be known) might also require moving out of deprecated functions.

rubenskuhl commented 9 years ago

WHMCS Version 6.0 supports PHP 5.3.7 or later, including PHP 5.4, 5.5 and 5.6.

rubenskuhl commented 9 years ago

WHMCS Version 6.0 requires PHP Database Extension PDO

rubenskuhl commented 1 year ago

mysql_* functions that were removed still present in the code

rubenskuhl commented 1 year ago

Commit df07b5d replaced all database functions with Capsule calls. New table layout defined.