search

regl-project / regl-site

Code for the regl website
http://regl.party/
MIT License
3 stars 3 forks source link

Fix CodeMirror and Browser Module Sandbox #3

Closed gregtatum closed 6 years ago

gregtatum commented 6 years ago

@nkint here's my changes tonight. It looks like you had the --watch flag in the wrong place on budo, so you weren't getting the latest code changes.

I managed to fix the issue I had with the third party libraries. Essentially I needed to cache the DOM elements that they are injected into. The DOM diffing was deleting them.

gregtatum commented 6 years ago

I'm going to go ahead and merge this into the choo-upgrade branch, so we can move quickly and get the new site rolled out. Feel free to review my changes @nkint. I plan on PRing all work on the upgrade. Clicking on links is still broken, and the state management stuff for the editor is broken still.