search

regl-project / regl

👑 Functional WebGL
https://regl-project.github.io/
MIT License
5.21k stars 322 forks source link

Should throw an error when given invalid framebuffer properties #397

Open rreusser opened 7 years ago

rreusser commented 7 years ago

regl.framebuffer({foo: 'bar'}) doesn't throw an error about invalid property names. In particular data does not throw an error which has lead to some confusion due to the otherwise similar (in some cases feels almost interchangeable) behavior compared to regl.texture.

Edit: retroactive apologies for the 'should' wording.

rreusser commented 7 years ago

(tried to come up with a PR but that's gonna takes some time to work through where that would happen)

mikolalysenko commented 6 years ago

This makes some sense, could be added as a special check.